Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl_unittest.cc

Issue 2146223002: Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc b/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
index 7766f72e0d2aecc16b2c085a1fae8c522d59ce18..ec196944b70c8060f6dcff6268d2666290faea7b 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl_unittest.cc
@@ -26,6 +26,7 @@
#include "base/task_scheduler/task_tracker.h"
#include "base/task_scheduler/test_task_factory.h"
#include "base/task_scheduler/test_utils.h"
+#include "base/task_scheduler/worker_pool_params.h"
#include "base/threading/platform_thread.h"
#include "base/threading/simple_thread.h"
#include "base/threading/thread_restrictions.h"
@@ -63,8 +64,8 @@ class TaskSchedulerWorkerPoolImplTest
void SetUp() override {
worker_pool_ = SchedulerWorkerPoolImpl::Create(
- "TestWorkerPoolWithFileIO", ThreadPriority::NORMAL,
- kNumWorkersInWorkerPool, IORestriction::ALLOWED,
+ WorkerPoolParams("TestWorkerPoolWithFileIO", ThreadPriority::NORMAL,
+ IORestriction::ALLOWED, kNumWorkersInWorkerPool),
Bind(&TaskSchedulerWorkerPoolImplTest::ReEnqueueSequenceCallback,
Unretained(this)),
&task_tracker_, &delayed_task_manager_);
@@ -363,7 +364,8 @@ TEST_P(TaskSchedulerWorkerPoolImplIORestrictionTest, IORestriction) {
DelayedTaskManager delayed_task_manager(Bind(&DoNothing));
auto worker_pool = SchedulerWorkerPoolImpl::Create(
- "TestWorkerPoolWithParam", ThreadPriority::NORMAL, 1U, GetParam(),
+ WorkerPoolParams("TestWorkerPoolWithParam", ThreadPriority::NORMAL,
+ GetParam(), 1U),
Bind(&NotReachedReEnqueueSequenceCallback), &task_tracker,
&delayed_task_manager);
ASSERT_TRUE(worker_pool);

Powered by Google App Engine
This is Rietveld 408576698