Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams

base/task_scheduler/worker_pool_params.h

Index: base/task_scheduler/worker_pool_params.h
diff --git a/base/task_scheduler/worker_pool_params.h b/base/task_scheduler/worker_pool_params.h
new file mode 100644
index 0000000000000000000000000000000000000000..af9747c39f7e6048413ee259248a99c1b9fd9328
--- /dev/null
+++ b/base/task_scheduler/worker_pool_params.h
@@ -0,0 +1,56 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BASE_TASK_SCHEDULER_WORKER_POOL_PARAMS_H_
+#define BASE_TASK_SCHEDULER_WORKER_POOL_PARAMS_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "base/task_scheduler/scheduler_worker_pool_impl.h"

[fdoray, 2016/07/19 18:24:49]

Maybe define IORestriction in WorkerPoolParams to avoid this include?

[robliao, 2016/07/19 20:34:55]

Done.

+#include "base/threading/platform_thread.h"
+
+namespace base {
+namespace internal {
+
+class BASE_EXPORT WorkerPoolParams final {
+ public:
+  // Construct a worker pool parameter object that instructs a worker pool to
+  // use the label |name| and create up to |max_threads| threads of priority
+  // |thread_priority|. |io_restriction| indicates whether Tasks on the worker
+  // pool are allowed to make I/O calls.
+  WorkerPoolParams(
+      const std::string& name,
+      ThreadPriority thread_priority,
+      SchedulerWorkerPoolImpl::IORestriction io_restriction,
+      int max_threads);
+  WorkerPoolParams(WorkerPoolParams&& other);

[gab, 2016/07/19 18:04:08]

Also need to declare default move-assignment operator per-style guide even
though it's unnecessary for STL.

https://google.github.io/styleguide/cppguide.html#Copyable_Movable_Types

" If you define a copy or move constructor, define the corresponding assignment
operator, and vice-versa."

[robliao, 2016/07/19 20:34:55]

Ah yup, you're right! Done.

+
+  // Name of the pool. Used to label the pool's threads.
+  const std::string& name() const { return name_; }
+
+  // Priority of the pool's threads.
+  ThreadPriority thread_priority() const { return thread_priority_; }
+
+  // Whether I/O is allowed in the pool.
+  SchedulerWorkerPoolImpl::IORestriction io_restriction() const {
+    return io_restriction_;
+  }
+
+  // Maximum number of threads in the pool.
+  size_t max_threads() const { return max_threads_; }
+
+ private:
+  std::string name_;
+  ThreadPriority thread_priority_;
+  SchedulerWorkerPoolImpl::IORestriction io_restriction_;
+  size_t max_threads_;
+
+  DISALLOW_COPY_AND_ASSIGN(WorkerPoolParams);
+};
+
+}  // namespace internal
+}  // namespace base
+
+#endif  // BASE_TASK_SCHEDULER_WORKER_POOL_PARAMS_H_