Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Unified Diff: base/task_scheduler/scheduler_worker_pool_impl.cc

Issue 2146223002: Refactor WorkerPoolCreationArgs to a Read-Only WorkerPoolParams (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: CR Feedback Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/task_scheduler/scheduler_worker_pool_impl.cc
diff --git a/base/task_scheduler/scheduler_worker_pool_impl.cc b/base/task_scheduler/scheduler_worker_pool_impl.cc
index 06933eb32db62386195ba3619fd71c03914346fd..604bcc02e73d9d61c05711e2250333190b4fc00f 100644
--- a/base/task_scheduler/scheduler_worker_pool_impl.cc
+++ b/base/task_scheduler/scheduler_worker_pool_impl.cc
@@ -18,6 +18,7 @@
#include "base/strings/stringprintf.h"
#include "base/task_scheduler/delayed_task_manager.h"
#include "base/task_scheduler/task_tracker.h"
+#include "base/task_scheduler/worker_pool_params.h"
#include "base/threading/platform_thread.h"
#include "base/threading/thread_local.h"
#include "base/threading/thread_restrictions.h"
@@ -227,17 +228,16 @@ SchedulerWorkerPoolImpl::~SchedulerWorkerPoolImpl() {
// static
std::unique_ptr<SchedulerWorkerPoolImpl> SchedulerWorkerPoolImpl::Create(
- StringPiece name,
- ThreadPriority thread_priority,
- size_t max_threads,
- IORestriction io_restriction,
+ const WorkerPoolParams& params,
const ReEnqueueSequenceCallback& re_enqueue_sequence_callback,
TaskTracker* task_tracker,
DelayedTaskManager* delayed_task_manager) {
std::unique_ptr<SchedulerWorkerPoolImpl> worker_pool(
- new SchedulerWorkerPoolImpl(name, io_restriction, task_tracker,
- delayed_task_manager));
- if (worker_pool->Initialize(thread_priority, max_threads,
+ new SchedulerWorkerPoolImpl(params.name(),
+ params.io_restriction(),
+ task_tracker, delayed_task_manager));
+ if (worker_pool->Initialize(params.thread_priority(),
+ params.max_threads(),
re_enqueue_sequence_callback)) {
return worker_pool;
}

Powered by Google App Engine
This is Rietveld 408576698