Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2146063006: [DevTools] Move Timestamp to Runtime, measure it in milliseconds. (Closed)

Created:
4 years, 5 months ago by dgozman
Modified:
4 years, 5 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2139543002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move Timestamp to Runtime, measure it in milliseconds. BUG=613882 Committed: https://crrev.com/ea82fa08563b077af8b1acba4d81559974acd149 Cr-Commit-Position: refs/heads/master@{#405762}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -17 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 7 chunks +10 lines, -11 lines 0 comments Download

Depends on Patchset:

Issue 2139543002 Patch 100001

Messages

Total messages: 9 (3 generated)
dgozman
Take a look please.
4 years, 5 months ago (2016-07-15 00:36:10 UTC) #2
kozy
lgtm
4 years, 5 months ago (2016-07-15 01:07:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2146063006/1
4 years, 5 months ago (2016-07-15 14:30:56 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-15 16:08:01 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 16:08:07 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 16:09:41 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ea82fa08563b077af8b1acba4d81559974acd149
Cr-Commit-Position: refs/heads/master@{#405762}

Powered by Google App Engine
This is Rietveld 408576698