third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp - Issue 2146063006: [DevTools] Move Timestamp to Runtime, measure it in milliseconds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

Issue 2146063006: [DevTools] Move Timestamp to Runtime, measure it in milliseconds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2139543002

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js ('k') | third_party/WebKit/Source/platform/v8_inspector/js_protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

index 4aaa3598844000dde81d4cfe9e2a8552a9c8728d..c970fb40460dd1de0431d563a34459a74a852770 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp

@@ -241,7 +241,7 @@ void V8ConsoleMessage::reportToFrontend(protocol::Console::Frontend* frontend, V

.setSource(messageSourceValue(m_source))

.setLevel(messageLevelValue(m_level))

.setText(m_message)

- .setTimestamp(m_timestamp / 1000) // TODO(dgozman): migrate this to milliseconds.

+ .setTimestamp(m_timestamp)

.build();

result->setLine(static_cast<int>(m_lineNumber));

result->setColumn(static_cast<int>(m_columnNumber));

@@ -317,7 +317,7 @@ void V8ConsoleMessage::reportToFrontend(protocol::Runtime::Frontend* frontend, V

return;

}

if (m_origin == V8MessageOrigin::kRevokedException) {

- frontend->exceptionRevoked(m_timestamp, m_message, m_revokedExceptionId);

+ frontend->exceptionRevoked(m_message, m_revokedExceptionId);

return;

}

if (m_origin == V8MessageOrigin::kConsole) {