Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 2145753007: Make webkit_modules a split static library in non-component builds. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
brucedawson
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make webkit_modules a split static library in non-component builds. Previously this was forced to a source set because it was too large for official Windows builds to handle as a static library. This uses the split_static_library template for non-component official Windows builds so it can be a static library now. Updates the split_static_library template to handle the case where an output name is specified. BUG=627637 Previously landed version of http://crrev.com/2145253003 with addition of split_static_library change. Committed: https://crrev.com/251c55188818138cba319ca20d843b30c71d3137 Cr-Commit-Position: refs/heads/master@{#405797}

Patch Set 1 #

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M build/split_static_library.gni View 1 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/BUILD.gn View 2 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
brettw
The change from the previous one is the split_static_library template (it was generating libraries with ...
4 years, 5 months ago (2016-07-15 16:41:16 UTC) #2
brettw
comment
4 years, 5 months ago (2016-07-15 16:42:16 UTC) #3
brucedawson
lgtm
4 years, 5 months ago (2016-07-15 17:09:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145753007/20001
4 years, 5 months ago (2016-07-15 17:14:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-15 18:21:41 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-15 18:21:59 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-15 18:23:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/251c55188818138cba319ca20d843b30c71d3137
Cr-Commit-Position: refs/heads/master@{#405797}

Powered by Google App Engine
This is Rietveld 408576698