Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: third_party/WebKit/Source/modules/BUILD.gn

Issue 2145753007: Make webkit_modules a split static library in non-component builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/split_static_library.gni ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/BUILD.gn
diff --git a/third_party/WebKit/Source/modules/BUILD.gn b/third_party/WebKit/Source/modules/BUILD.gn
index d6f07d823f48b6afe211476007b7ffffff5b7153..c0040571b3bcca12d6d0d534c96201596a4bdefd 100644
--- a/third_party/WebKit/Source/modules/BUILD.gn
+++ b/third_party/WebKit/Source/modules/BUILD.gn
@@ -2,6 +2,7 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+import("//build/split_static_library.gni")
import("//third_party/WebKit/Source/bindings/bindings.gni")
import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni")
import("//third_party/WebKit/Source/bindings/modules/v8/v8.gni")
@@ -10,16 +11,20 @@ import("//third_party/WebKit/Source/modules/modules.gni")
visibility = [ "//third_party/WebKit/Source/*" ]
-# GYP version: WebKit/Source/modules/modules.gyp:modules
-component("modules") {
+if (!is_component_build && is_win && is_official_build) {
+ # This target as a static library (for non-component builds) is >2GB for
+ # official builds on Windows. This causes linking fail. As a workaround,
+ # force using a split static library for this configuration.
+ modules_target_type = "split_static_library"
+} else {
+ modules_target_type = "component"
+}
+
+target(modules_target_type, "modules") {
output_name = "blink_modules"
- if (is_win && is_official_build) {
- # This target is >2GB for official builds on Windows which causes linking
- # with the library to fail. As a workaround, force using a source set in
- # this configuration whcih avoids generating the .lib file (although will
- # cause slower links).
- static_component_type = "source_set"
+ if (modules_target_type == "split_static_library") {
+ split_count = 5
}
visibility = [] # Allow re-assignment of list.
« no previous file with comments | « build/split_static_library.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698