Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Side by Side Diff: third_party/WebKit/Source/modules/BUILD.gn

Issue 2145753007: Make webkit_modules a split static library in non-component builds. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/split_static_library.gni ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/split_static_library.gni")
5 import("//third_party/WebKit/Source/bindings/bindings.gni") 6 import("//third_party/WebKit/Source/bindings/bindings.gni")
6 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni") 7 import("//third_party/WebKit/Source/bindings/modules/v8/generated.gni")
7 import("//third_party/WebKit/Source/bindings/modules/v8/v8.gni") 8 import("//third_party/WebKit/Source/bindings/modules/v8/v8.gni")
8 import("//third_party/WebKit/Source/build/scripts/scripts.gni") 9 import("//third_party/WebKit/Source/build/scripts/scripts.gni")
9 import("//third_party/WebKit/Source/modules/modules.gni") 10 import("//third_party/WebKit/Source/modules/modules.gni")
10 11
11 visibility = [ "//third_party/WebKit/Source/*" ] 12 visibility = [ "//third_party/WebKit/Source/*" ]
12 13
13 # GYP version: WebKit/Source/modules/modules.gyp:modules 14 if (!is_component_build && is_win && is_official_build) {
14 component("modules") { 15 # This target as a static library (for non-component builds) is >2GB for
16 # official builds on Windows. This causes linking fail. As a workaround,
17 # force using a split static library for this configuration.
18 modules_target_type = "split_static_library"
19 } else {
20 modules_target_type = "component"
21 }
22
23 target(modules_target_type, "modules") {
15 output_name = "blink_modules" 24 output_name = "blink_modules"
16 25
17 if (is_win && is_official_build) { 26 if (modules_target_type == "split_static_library") {
18 # This target is >2GB for official builds on Windows which causes linking 27 split_count = 5
19 # with the library to fail. As a workaround, force using a source set in
20 # this configuration whcih avoids generating the .lib file (although will
21 # cause slower links).
22 static_component_type = "source_set"
23 } 28 }
24 29
25 visibility = [] # Allow re-assignment of list. 30 visibility = [] # Allow re-assignment of list.
26 visibility = [ "//third_party/WebKit/*" ] 31 visibility = [ "//third_party/WebKit/*" ]
27 32
28 sources = rebase_path(modules_files, ".", "//") 33 sources = rebase_path(modules_files, ".", "//")
29 sources += bindings_modules_v8_files 34 sources += bindings_modules_v8_files
30 sources += rebase_path(bindings_modules_generated_aggregate_files, ".", "//") 35 sources += rebase_path(bindings_modules_generated_aggregate_files, ".", "//")
31 sources += rebase_path(bindings_modules_generated_union_type_files, ".", "//") 36 sources += rebase_path(bindings_modules_generated_union_type_files, ".", "//")
32 sources += 37 sources +=
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 } 122 }
118 123
119 # GYP version: WebKit/Source/modules/modules_generated.gyp:make_modules_generate d 124 # GYP version: WebKit/Source/modules/modules_generated.gyp:make_modules_generate d
120 group("make_modules_generated") { 125 group("make_modules_generated") {
121 public_deps = [ 126 public_deps = [
122 ":module_names", 127 ":module_names",
123 "//third_party/WebKit/Source/bindings/modules:bindings_modules_generated", 128 "//third_party/WebKit/Source/bindings/modules:bindings_modules_generated",
124 "//third_party/WebKit/Source/core:core_event_interfaces", 129 "//third_party/WebKit/Source/core:core_event_interfaces",
125 ] 130 ]
126 } 131 }
OLDNEW
« no previous file with comments | « build/split_static_library.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698