Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 214563003: Revert of use v8 Microtask Queue (Closed)

Created:
6 years, 9 months ago by tkent
Modified:
6 years, 9 months ago
Reviewers:
haraken, adamk, rafaelw
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, eae+blinkwatch, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive
Visibility:
Public.

Description

Revert of use v8 Microtask Queue (https://codereview.chromium.org/167683003/) Reason for revert: It seems this caused many memory leaks. http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%281%29/builds/807/steps/browser_tests/logs/stdio Original issue's description: > Use v8 Microtask Queue > > V8 now hosts the end-of-microtask work queue. This allows consistent > scheduling of microtask work regardless of where it is implemented (v8 vs blink). > > R=adamk@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169978 TBR=adamk@chromium.org,haraken@chromium.org,rafaelw@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -45 lines) Patch
M LayoutTests/inspector/sources/debugger/async-callstack-mutation-observer-expected.txt View 6 chunks +0 lines, -10 lines 0 comments Download
M Source/bindings/v8/ScriptRegexp.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/dom/Microtask.cpp View 1 chunk +17 lines, -26 lines 0 comments Download
M Source/web/WebKit.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
Created Revert of use v8 Microtask Queue
6 years, 9 months ago (2014-03-27 10:14:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/214563003/1
6 years, 9 months ago (2014-03-27 10:14:22 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-03-27 10:14:41 UTC) #3
Message was sent while issue was closed.
Change committed as 170159

Powered by Google App Engine
This is Rietveld 408576698