Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: Source/core/dom/Microtask.cpp

Issue 214563003: Revert of use v8 Microtask Queue (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/V8PerIsolateData.cpp ('k') | Source/web/WebKit.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/dom/Microtask.h" 32 #include "core/dom/Microtask.h"
33 33
34 #include "bindings/v8/V8PerIsolateData.h" 34 #include "bindings/v8/V8PerIsolateData.h"
35 #include "wtf/Vector.h" 35 #include "wtf/Vector.h"
36 #include <v8.h>
37 36
38 namespace WebCore { 37 namespace WebCore {
39 38
39 typedef Vector<MicrotaskCallback> MicrotaskQueue;
40
41 static MicrotaskQueue& microtaskQueue()
42 {
43 DEFINE_STATIC_LOCAL(MicrotaskQueue, microtaskQueue, ());
44 return microtaskQueue;
45 }
46
40 void Microtask::performCheckpoint() 47 void Microtask::performCheckpoint()
41 { 48 {
42 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 49 V8PerIsolateData* isolateData = V8PerIsolateData::current();
43 V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate);
44 ASSERT(isolateData); 50 ASSERT(isolateData);
45 if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpo int()) 51 if (isolateData->recursionLevel() || isolateData->performingMicrotaskCheckpo int())
46 return; 52 return;
47 isolateData->setPerformingMicrotaskCheckpoint(true); 53 isolateData->setPerformingMicrotaskCheckpoint(true);
48 54
49 v8::HandleScope handleScope(isolate); 55 while (!microtaskQueue().isEmpty()) {
50 v8::Local<v8::Context> context = isolateData->ensureDomInJSContext(); 56 Vector<MicrotaskCallback> microtasks;
51 v8::Context::Scope scope(context); 57 microtasks.swap(microtaskQueue());
52 v8::V8::RunMicrotasks(isolate); 58 for (size_t i = 0; i < microtasks.size(); ++i) {
59 microtasks[i]();
60 }
61 }
53 62
54 isolateData->setPerformingMicrotaskCheckpoint(false); 63 isolateData->setPerformingMicrotaskCheckpoint(false);
55 } 64 }
56 65
57 COMPILE_ASSERT(sizeof(void*) == sizeof(MicrotaskCallback), VoidPtrAndFunctionPtr AreSameSize);
58
59 static void microtaskFunctionCallback(const v8::FunctionCallbackInfo<v8::Value>& info)
60 {
61 MicrotaskCallback callback =
62 reinterpret_cast<MicrotaskCallback>(reinterpret_cast<intptr_t>(
63 info.Data().As<v8::External>()->Value()));
64 (*callback)();
65 }
66
67 void Microtask::enqueueMicrotask(MicrotaskCallback callback) 66 void Microtask::enqueueMicrotask(MicrotaskCallback callback)
68 { 67 {
69 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 68 microtaskQueue().append(callback);
70 V8PerIsolateData* isolateData = V8PerIsolateData::from(isolate);
71 v8::HandleScope handleScope(isolate);
72 v8::Local<v8::Context> context = isolateData->ensureDomInJSContext();
73 v8::Context::Scope scope(context);
74 v8::Local<v8::External> handler =
75 v8::External::New(isolate,
76 reinterpret_cast<void*>(reinterpret_cast<intptr_t>(callback)));
77 v8::V8::EnqueueMicrotask(isolate, v8::Function::New(isolate, &microtaskFunct ionCallback, handler));
78 } 69 }
79 70
80 } // namespace WebCore 71 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8PerIsolateData.cpp ('k') | Source/web/WebKit.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698