Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 2144813002: Cleanup some PWL interfaces. (Closed)

Created:
4 years, 5 months ago by dsinclair
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@ifx_cleanup
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Cleanup some PWL interfaces. This CL removes IPWL_Edit_Notfy and removes the OnKillFocus override from IPWL_FocusHandler. Committed: https://pdfium.googlesource.com/pdfium/+/dbc7716e1b8d67a5ca422ef0bbfe87ff8c5cf4ea

Patch Set 1 #

Patch Set 2 : Rebase to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -127 lines) Patch
M fpdfsdk/formfiller/cffl_combobox.h View 2 chunks +1 line, -7 lines 0 comments Download
M fpdfsdk/formfiller/cffl_combobox.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.h View 2 chunks +1 line, -7 lines 0 comments Download
M fpdfsdk/formfiller/cffl_textfield.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M fpdfsdk/fxedit/fxet_edit.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M fpdfsdk/fxedit/include/fxet_edit.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.h View 2 chunks +0 lines, -3 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Edit.cpp View 8 chunks +0 lines, -42 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.h View 4 chunks +0 lines, -34 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_EditCtrl.cpp View 1 2 chunks +5 lines, -10 lines 0 comments Download
M fpdfsdk/pdfwindow/PWL_Wnd.h View 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
dsinclair
PTAL.
4 years, 5 months ago (2016-07-12 20:57:58 UTC) #2
Lei Zhang
... because all the impls do nothing, right? also s/iterfaces/interfaces/
4 years, 5 months ago (2016-07-12 21:38:40 UTC) #3
dsinclair
On 2016/07/12 21:38:40, Lei Zhang wrote: > ... because all the impls do nothing, right? ...
4 years, 5 months ago (2016-07-13 14:07:49 UTC) #5
Lei Zhang
lgtm
4 years, 5 months ago (2016-07-13 18:00:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144813002/20001
4 years, 5 months ago (2016-07-13 18:27:32 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 18:34:29 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/dbc7716e1b8d67a5ca422ef0bbfe87ff8c5c...

Powered by Google App Engine
This is Rietveld 408576698