Remove some IFX_* wrappers.

Remove some IFX_* wrappers.

This CL removes the IFX_* wrappers between fpdfsdk/fxedit and fpdfsdk/pdfwindow
which only have a single implementation.

Committed: https://pdfium.googlesource.com/pdfium/+/e35af1e3c93e5e1f374799da115eb4b99820831c

[dsinclair, 2016-07-12 20:56:30]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, weili@chromium.org

[dsinclair, 2016-07-12 20:56:30]

PTAL.

[Lei Zhang, 2016-07-12 21:36:46]

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_edit.cpp
File fpdfsdk/fxedit/fxet_edit.cpp (left):

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_edit.cp...
fpdfsdk/fxedit/fxet_edit.cpp:1827: if (m_bNotify && m_pNotify) {
Why is this removed?

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_list.cpp
File fpdfsdk/fxedit/fxet_list.cpp (right):

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_list.cp...
fpdfsdk/fxedit/fxet_list.cpp:206: void CFX_ListCtrl::SetNotify(CPWL_List_Notify*
pNotify) {
Convert to unique_ptr?

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_list.cp...
fpdfsdk/fxedit/fxet_list.cpp:620: void CFX_ListCtrl::Empty() {
Can we rename these to Clear() later?

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/include/fx_e...
File fpdfsdk/fxedit/include/fx_edit.h (left):

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/include/fx_e...
fpdfsdk/fxedit/include/fx_edit.h:204: // if the text is shown in secret , set a
character for substitute.
Are any of the comments useful? Maybe this one?

[dsinclair, 2016-07-13 14:05:46]

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_edit.cpp
File fpdfsdk/fxedit/fxet_edit.cpp (left):

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_edit.cp...
fpdfsdk/fxedit/fxet_edit.cpp:1827: if (m_bNotify && m_pNotify) {
On 2016/07/12 21:36:46, Lei Zhang wrote:
> Why is this removed?

Because IOnSetScrollPosX() did nothing and was removed. Without that, this block
does nothing.

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_list.cpp
File fpdfsdk/fxedit/fxet_list.cpp (right):

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_list.cp...
fpdfsdk/fxedit/fxet_list.cpp:206: void CFX_ListCtrl::SetNotify(CPWL_List_Notify*
pNotify) {
On 2016/07/12 21:36:46, Lei Zhang wrote:
> Convert to unique_ptr?

This is a mistake. The notify should not be owned by the ListCtrl. Reverted.

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/fxet_list.cp...
fpdfsdk/fxedit/fxet_list.cpp:620: void CFX_ListCtrl::Empty() {
On 2016/07/12 21:36:46, Lei Zhang wrote:
> Can we rename these to Clear() later?

Acknowledged.

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/include/fx_e...
File fpdfsdk/fxedit/include/fx_edit.h (left):

https://codereview.chromium.org/2142213002/diff/1/fpdfsdk/fxedit/include/fx_e...
fpdfsdk/fxedit/include/fx_edit.h:204: // if the text is shown in secret , set a
character for substitute.
On 2016/07/12 21:36:46, Lei Zhang wrote:
> Are any of the comments useful? Maybe this one?

Copied a few of them.

[Lei Zhang, 2016-07-13 18:01:26]

lgtm

[dsinclair, 2016-07-13 18:08:21]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-07-13 18:08:21]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2142213002/#ps40001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-07-13 18:08:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 18:26:23]

Description was changed from

==========
Remove some IFX_* wrappers.

This CL removes the IFX_* wrappers between fpdfsdk/fxedit and fpdfsdk/pdfwindow
which only have a single implementation.
==========

to

==========
Remove some IFX_* wrappers.

This CL removes the IFX_* wrappers between fpdfsdk/fxedit and fpdfsdk/pdfwindow
which only have a single implementation.

Committed:
https://pdfium.googlesource.com/pdfium/+/e35af1e3c93e5e1f374799da115eb4b99820...
==========

[commit-bot: I haz the power, 2016-07-13 18:26:24]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/e35af1e3c93e5e1f374799da115eb4b99820...