Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2144643004: [builtins] Turn StoreIC_Miss and StoreIC_Slow builtins to TurboFan code stubs. (Closed)

Created:
4 years, 5 months ago by Igor Sheludko
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Turn StoreIC_Miss and StoreIC_Slow builtins to TurboFan code stubs. This CL also combines Runtime::GetGlobalInsideTypeof and Runtime::kGetGlobalNotInsideTypeof to Runtime::GetGlobal with explicit typeof_mode parameter. Drive-by-fix: tail call to correct Slow builtin from LoadCallback handlers when --runtime-call-stats is on. BUG=chromium:576312 Committed: https://crrev.com/7ae653f79b20fd3341d7d6e9ba843b69fa39c4a1 Cr-Commit-Position: refs/heads/master@{#37710}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -184 lines) Patch
M src/builtins.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/builtins.cc View 2 chunks +45 lines, -15 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/handler-compiler.h View 4 chunks +4 lines, -17 lines 0 comments Download
M src/ic/handler-compiler.cc View 2 chunks +16 lines, -22 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/ic.h View 1 chunk +9 lines, -1 line 0 comments Download
M src/ic/ic.cc View 4 chunks +4 lines, -19 lines 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/ppc/handler-compiler-ppc.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/s390/handler-compiler-s390.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/runtime/runtime.h View 2 chunks +1 line, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 4 chunks +9 lines, -24 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Igor Sheludko
PTAL
4 years, 5 months ago (2016-07-13 11:17:23 UTC) #5
Benedikt Meurer
LGTM on compiler.
4 years, 5 months ago (2016-07-13 11:19:10 UTC) #7
Jakob Kummerow
lgtm
4 years, 5 months ago (2016-07-13 12:05:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144643004/1
4 years, 5 months ago (2016-07-13 12:06:57 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 12:10:02 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 12:12:51 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ae653f79b20fd3341d7d6e9ba843b69fa39c4a1
Cr-Commit-Position: refs/heads/master@{#37710}

Powered by Google App Engine
This is Rietveld 408576698