Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Unified Diff: src/ic/handler-compiler.h

Issue 2144643004: [builtins] Turn StoreIC_Miss and StoreIC_Slow builtins to TurboFan code stubs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/handler-compiler.h
diff --git a/src/ic/handler-compiler.h b/src/ic/handler-compiler.h
index a571f4f6bbbefc562f7f43f5a7c16a649c7fc60f..cc713eea1cab808d9c1d9ef91b28bffb3c92ae4e 100644
--- a/src/ic/handler-compiler.h
+++ b/src/ic/handler-compiler.h
@@ -123,11 +123,12 @@ class NamedLoadHandlerCompiler : public PropertyHandlerCompiler {
Handle<Code> CompileLoadField(Handle<Name> name, FieldIndex index);
Handle<Code> CompileLoadCallback(Handle<Name> name,
- Handle<AccessorInfo> callback);
+ Handle<AccessorInfo> callback,
+ Handle<Code> slow_stub);
Handle<Code> CompileLoadCallback(Handle<Name> name,
const CallOptimization& call_optimization,
- int accessor_index);
+ int accessor_index, Handle<Code> slow_stub);
Handle<Code> CompileLoadConstant(Handle<Name> name, int constant_index);
@@ -226,7 +227,7 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {
LanguageMode language_mode);
Handle<Code> CompileStoreCallback(Handle<JSObject> object, Handle<Name> name,
const CallOptimization& call_optimization,
- int accessor_index);
+ int accessor_index, Handle<Code> slow_stub);
Handle<Code> CompileStoreViaSetter(Handle<JSObject> object, Handle<Name> name,
int accessor_index,
int expected_arguments);
@@ -241,8 +242,6 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {
no_reg);
}
- static void GenerateSlow(MacroAssembler* masm);
-
protected:
virtual Register FrontendHeader(Register object_reg, Handle<Name> name,
Label* miss, ReturnHolder return_what);
@@ -267,18 +266,6 @@ class NamedStoreHandlerCompiler : public PropertyHandlerCompiler {
void GenerateFieldTypeChecks(FieldType* field_type, Register value_reg,
Label* miss_label);
- static Builtins::Name SlowBuiltin(Code::Kind kind) {
- switch (kind) {
- case Code::STORE_IC:
- return Builtins::kStoreIC_Slow;
- case Code::KEYED_STORE_IC:
- return Builtins::kKeyedStoreIC_Slow;
- default:
- UNREACHABLE();
- }
- return Builtins::kStoreIC_Slow;
- }
-
static Register value();
};
« no previous file with comments | « src/ic/arm64/handler-compiler-arm64.cc ('k') | src/ic/handler-compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698