Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 2144593003: Merge dom node and node unit types. (Closed)

Created:
4 years, 5 months ago by David Tseng
Modified:
4 years, 5 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, arv+watch_chromium.org, chromium-reviews, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, je_julie, nektar+watch_chromium.org, oshima+watch_chromium.org, yuzo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Merge dom node and node unit types. This eliminates the distinction between node and dom node movement of a cursor. A "node" is everything other than a inline textbox. A line, word, or character move are now the only units of movement that can move a cursor or range into an inline textbox. Once constructed, a range passed to output uses the leafDomNode predicate (which matches against both inline textboxes if starting from an inline textbox or against "nodes"). This fixes the $descendants format token which used to collect inline textbox nodes for output. It now visits only static text nodes and other leaf "nodes". CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/cd537786815caff750ec5128e2a994b9d14ab2a5 Cr-Commit-Position: refs/heads/master@{#406596}

Patch Set 1 : m #

Patch Set 2 : m #

Patch Set 3 : Rebase. #

Patch Set 4 : Fix test. #

Messages

Total messages: 26 (13 generated)
David Tseng
4 years, 5 months ago (2016-07-12 20:47:31 UTC) #6
dmazzoni
lgtm
4 years, 5 months ago (2016-07-13 23:42:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144593003/40001
4 years, 5 months ago (2016-07-19 21:59:59 UTC) #9
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-19 22:00:01 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/98571) ios-device on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 5 months ago (2016-07-19 22:03:49 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144593003/80001
4 years, 5 months ago (2016-07-19 22:52:38 UTC) #16
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-19 22:52:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/98572)
4 years, 5 months ago (2016-07-19 22:55:34 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2144593003/80001
4 years, 5 months ago (2016-07-20 16:39:27 UTC) #21
commit-bot: I haz the power
Your CL relies on deprecated CQ feature(s): * Specifying master names in CQ_INCLUDE_TRYBOTS part of ...
4 years, 5 months ago (2016-07-20 16:39:29 UTC) #22
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 5 months ago (2016-07-20 17:18:31 UTC) #23
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 17:18:44 UTC) #24
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:20:49 UTC) #26
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cd537786815caff750ec5128e2a994b9d14ab2a5
Cr-Commit-Position: refs/heads/master@{#406596}

Powered by Google App Engine
This is Rietveld 408576698