chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js - Issue 2144593003: Merge dom node and node unit types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

Issue 2144593003: Merge dom node and node unit types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/cursors.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

index a12746031dc1b2101ed3beaa8174a5a0da17b8e4..474ab3751175d96f915efa99f28a8f942522534c 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js

@@ -314,11 +314,11 @@ CommandHandler.onCommand = function(command) {

break;

case 'right':

case 'nextObject':

- current = current.move(cursors.Unit.DOM_NODE, Dir.FORWARD);

+ current = current.move(cursors.Unit.NODE, Dir.FORWARD);

break;

case 'left':

case 'previousObject':

- current = current.move(cursors.Unit.DOM_NODE, Dir.BACKWARD);

+ current = current.move(cursors.Unit.NODE, Dir.BACKWARD);

break;

case 'jumpToTop':

var node = AutomationUtil.findNodePost(

@@ -352,7 +352,7 @@ CommandHandler.onCommand = function(command) {

var prevRange = ChromeVoxState.instance.currentRange_;

var newRange =

ChromeVoxState.instance.currentRange_.move(

- cursors.Unit.DOM_NODE, Dir.FORWARD);

+ cursors.Unit.NODE, Dir.FORWARD);

// Stop if we've wrapped back to the document.

var maybeDoc = newRange.start.node;