chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs - Issue 2144593003: Merge dom node and node unit types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs

Issue 2144593003: Merge dom node and node unit types. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util.js ('k') | chrome/browser/resources/chromeos/chromevox/cvox2/background/command_handler.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs

index 74168c30169d7a3bb0463a572967c8dc7125b053..7461eca403c375385e2ab653c65b61e00c18ad40 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/automation_util_test.extjs

@@ -123,9 +123,11 @@ TEST_F('AutomationUtilE2ETest', 'GetDirection', function() {

// Same node.

assertEquals(Dir.FORWARD, AutomationUtil.getDirection(left, right));

- // Ancestor.

+ // Ancestry.

left = left.firstChild;

- assertEquals(Dir.FORWARD, AutomationUtil.getDirection(left, right));

+ // Upward movement is backward (in dfs).

+ assertEquals(Dir.BACKWARD, AutomationUtil.getDirection(left, right));

+ // Downward movement is forward.

assertEquals(Dir.FORWARD, AutomationUtil.getDirection(right, left));

// Ordered.