Fix is_manual_test for files with no file extension.

Fix is_manual_test for files with no file extension.

In http://crrev.com/2132273002, I made an assumption that all
files have a "." character, which is incorrect. This is a follow-up
fix for that mistake.

BUG=626740
Committed: https://crrev.com/8313c6bc7a7b916b6e56d987a6110a5936aa47c8
Cr-Commit-Position: refs/heads/master@{#405790}

[qyearsley, 2016-07-14 17:21:54]

qyearsley@chromium.org changed reviewers:
+ rbyers@chromium.org

[qyearsley, 2016-07-14 17:57:16]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 17:57:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[qyearsley, 2016-07-14 17:58:18]

I think this needs to be fixed before doing another import, update-w3c-deps is
currently broken :-/

[commit-bot: I haz the power, 2016-07-14 19:11:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 19:11:20]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-07-14 20:04:06]

qyearsley@chromium.org changed reviewers:
+ tkent@chromium.org

[Rick Byers, 2016-07-15 15:24:50]

LGTM

[Rick Byers, 2016-07-15 15:29:50]

https://codereview.chromium.org/2144343002/diff/1/third_party/WebKit/Tools/Sc...
File third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py (right):

https://codereview.chromium.org/2144343002/diff/1/third_party/WebKit/Tools/Sc...
third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py:202:
basename_without_extension, _ = basename.rsplit('.', 1)
nit: this would be slightly simpler as:
basename_without_extension, _ = os.path.splitext(basename)

That appears to handle the no-dot case for you automatically (the extension is
the empty string).

[qyearsley, 2016-07-15 15:52:35]

The CQ bit was checked by qyearsley@chromium.org

[qyearsley, 2016-07-15 15:52:35]

The patchset sent to the CQ was uploaded after l-g-t-m from rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2144343002/#ps20001
(title: "Use splitext")

[commit-bot: I haz the power, 2016-07-15 15:52:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 18:03:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-15 18:03:51]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 18:05:09]

Description was changed from

==========
Fix is_manual_test for files with no file extension.

In http://crrev.com/2132273002, I made an assumption that all
files have a "." character, which is incorrect. This is a follow-up
fix for that mistake.

BUG=626740
==========

to

==========
Fix is_manual_test for files with no file extension.

In http://crrev.com/2132273002, I made an assumption that all
files have a "." character, which is incorrect. This is a follow-up
fix for that mistake.

BUG=626740

Committed: https://crrev.com/8313c6bc7a7b916b6e56d987a6110a5936aa47c8
Cr-Commit-Position: refs/heads/master@{#405790}
==========

[commit-bot: I haz the power, 2016-07-15 18:05:10]

Patchset 2 (id:??) landed as
https://crrev.com/8313c6bc7a7b916b6e56d987a6110a5936aa47c8
Cr-Commit-Position: refs/heads/master@{#405790}