Fix is_manual_test for files with no file extension.

third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Pull latest revisions of a W3C test repo and make a local commit."""
 
 import argparse
 import time
 
 from webkitpy.common.webkit_finder import WebKitFinder
@@ skipping 179 matching lines @@
             self.print_('## Done: changes imported and committed.')
         else:
             self.print_('## Done: no changes to import.')
 
     def is_manual_test(self, fs, dirname, basename):
         """Returns True if the file should be removed because it's a manual test.
 
         Tests with "-manual" in the name are not considered manual tests
         if there is a corresponding JS automation file.
         """
+        if '.' not in basename:
+            return False
         basename_without_extension, _ = basename.rsplit('.', 1)

[Rick Byers, 2016/07/15 15:29:49]

nit: this would be slightly simpler as:
basename_without_extension, _ = os.path.splitext(basename)

That appears to handle the no-dot case for you automatically (the extension is
the empty string).

         if not basename_without_extension.endswith('-manual'):
             return False
         dir_from_wpt = fs.relpath(dirname, self.path_from_webkit_base('LayoutTests', 'imported', 'wpt'))
         automation_dir = self.path_from_webkit_base('LayoutTests', 'imported', 'wpt_automation', dir_from_wpt)
         if fs.isfile(fs.join(automation_dir, '%s-automation.js' % basename_without_extension)):
             return False
         return True
 
     def is_baseline(self, fs, dirname, basename):  # Callback for FileSystem.files_under; not all arguments used - pylint: disable=unused-argument
         return basename.endswith('-expected.txt')
@@ skipping 73 matching lines @@
         sets['Failures'] -= sets['Successes']
         sets['Started'] -= sets['Successes']
         sets['Started'] -= sets['Failures']
         return sets
 
     def check_run(self, command):
         return_code, out = self.run(command)
         if return_code:
             raise Exception('%s failed with exit code %d.' % ' '.join(command), return_code)
         return out