third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py - Issue 2144343002: Fix is_manual_test for files with no file extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

Issue 2144343002: Fix is_manual_test for files with no file extension. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use splitext Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

index 152b5f74f9dc7b161a76efe9b60e841c55a1b9e6..31b7500f5dec870bbfbad27f5f7ad7b273f443e0 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py

@@ -197,7 +197,7 @@ class DepsUpdater(object):

Tests with "-manual" in the name are not considered manual tests

if there is a corresponding JS automation file.

"""

- basename_without_extension, _ = basename.rsplit('.', 1)

+ basename_without_extension, _ = self.fs.splitext(basename)

if not basename_without_extension.endswith('-manual'):

return False

dir_from_wpt = fs.relpath(dirname, self.path_from_webkit_base('LayoutTests', 'imported', 'wpt'))

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py » ('j') | no next file with comments »