Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2144333003: Remove prototypes from v8 functions that aren't constructors (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
haraken, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@2743
Target Ref:
refs/heads/chromium/2743
Project:
pdfium
Visibility:
Public.

Description

Remove prototypes from v8 functions that aren't constructors BUG=chromium:625823 TBR=haraken@chromium.org,thestig@chromium.org Review-Url: https://codereview.chromium.org/2123153002 (cherry picked from commit c4dedf32b1f5c71740df5be2a9b1446a01df304c) Committed: https://pdfium.googlesource.com/pdfium/+/e5effaf2556046b01265484922e0b8681790323b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -23 lines) Patch
M fpdfsdk/jsapi/fxjs_v8.cpp View 3 chunks +20 lines, -13 lines 0 comments Download
M xfa/fxjse/class.cpp View 3 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jochen (gone - plz use gerrit)
Committed patchset #1 (id:1) manually as e5effaf2556046b01265484922e0b8681790323b (tree was closed).
4 years, 5 months ago (2016-07-15 11:31:05 UTC) #2
haraken
4 years, 5 months ago (2016-07-15 13:48:46 UTC) #3
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698