Remove prototypes from v8 functions that aren't constructors

xfa/fxjse/class.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxjse/class.h"
 
 #include "xfa/fxjse/cfxjse_arguments.h"
 #include "xfa/fxjse/context.h"
@@ skipping 109 matching lines @@
                           szPropertyName,
                           reinterpret_cast<FXJSE_HVALUE>(lpPropValue));
   delete lpThisValue;
   lpThisValue = NULL;
   delete lpPropValue;
   lpPropValue = NULL;
 }
 
 static void FXJSE_V8ConstructorCallback_Wrapper(
     const v8::FunctionCallbackInfo<v8::Value>& info) {
+  if (!info.IsConstructCall()) {
+    return;
+  }
   const FXJSE_CLASS* lpClassDefinition =
       static_cast<FXJSE_CLASS*>(info.Data().As<v8::External>()->Value());
   if (!lpClassDefinition) {
     return;
   }
   ASSERT(info.This()->InternalFieldCount());
   info.This()->SetAlignedPointerInInternalField(0, NULL);
 }
 
 FXJSE_HRUNTIME CFXJSE_Arguments::GetRuntime() const {
@@ skipping 120 matching lines @@
           lpClassDefinition->properties[i].setProc
               ? FXJSE_V8SetterCallback_Wrapper
               : NULL,
           v8::External::New(pIsolate, const_cast<FXJSE_PROPERTY*>(
                                           lpClassDefinition->properties + i)),
           static_cast<v8::PropertyAttribute>(v8::DontDelete));
     }
   }
   if (lpClassDefinition->methNum) {
     for (int32_t i = 0; i < lpClassDefinition->methNum; i++) {
+      v8::Local<v8::FunctionTemplate> fun = v8::FunctionTemplate::New(
+          pIsolate, FXJSE_V8FunctionCallback_Wrapper,
+          v8::External::New(pIsolate, const_cast<FXJSE_FUNCTION*>(
+                                          lpClassDefinition->methods + i)));
+      fun->RemovePrototype();
       hObjectTemplate->Set(
           v8::String::NewFromUtf8(pIsolate, lpClassDefinition->methods[i].name),
-          v8::FunctionTemplate::New(
-              pIsolate, FXJSE_V8FunctionCallback_Wrapper,
-              v8::External::New(pIsolate, const_cast<FXJSE_FUNCTION*>(
-                                              lpClassDefinition->methods + i))),
+          fun,
           static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontDelete));
     }
   }
   if (lpClassDefinition->constructor) {
     if (bIsJSGlobal) {
       hObjectTemplate->Set(
           v8::String::NewFromUtf8(pIsolate, lpClassDefinition->name),
           v8::FunctionTemplate::New(
               pIsolate, FXJSE_V8ClassGlobalConstructorCallback_Wrapper,
               v8::External::New(pIsolate,
                                 const_cast<FXJSE_CLASS*>(lpClassDefinition))),
           static_cast<v8::PropertyAttribute>(v8::ReadOnly | v8::DontDelete));
     } else {
       v8::Local<v8::Context> hLocalContext =
           v8::Local<v8::Context>::New(pIsolate, lpContext->m_hContext);
       FXJSE_GetGlobalObjectFromContext(hLocalContext)
           ->Set(v8::String::NewFromUtf8(pIsolate, lpClassDefinition->name),
                 v8::Function::New(
                     pIsolate, FXJSE_V8ClassGlobalConstructorCallback_Wrapper,
                     v8::External::New(pIsolate, const_cast<FXJSE_CLASS*>(
                                                     lpClassDefinition))));
     }
   }
   if (bIsJSGlobal) {
-    hObjectTemplate->Set(
-        v8::String::NewFromUtf8(pIsolate, "toString"),
-        v8::FunctionTemplate::New(
-            pIsolate, FXJSE_Context_GlobalObjToString,
-            v8::External::New(pIsolate,
-                              const_cast<FXJSE_CLASS*>(lpClassDefinition))));
+    v8::Local<v8::FunctionTemplate> fun = v8::FunctionTemplate::New(
+        pIsolate, FXJSE_Context_GlobalObjToString,
+        v8::External::New(pIsolate,
+                          const_cast<FXJSE_CLASS*>(lpClassDefinition)));
+    fun->RemovePrototype();
+    hObjectTemplate->Set(v8::String::NewFromUtf8(pIsolate, "toString"), fun);
   }
   pClass->m_hTemplate.Reset(lpContext->m_pIsolate, hFunctionTemplate);
   lpContext->m_rgClasses.Add(pClass);
   return pClass;
 }
 CFXJSE_Class* CFXJSE_Class::GetClassFromContext(CFXJSE_Context* pContext,
                                                 const CFX_ByteStringC& szName) {
   for (int count = pContext->m_rgClasses.GetSize(), i = 0; i < count; i++) {
     CFXJSE_Class* pClass = pContext->m_rgClasses[i];
     if (pClass->m_szClassName == szName) {
       return pClass;
     }
   }
   return NULL;
 }