Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2123153002: Remove prototypes from v8 functions that aren't constructors (Closed)

Created:
4 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 5 months ago
Reviewers:
haraken, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -24 lines) Patch
M fpdfsdk/jsapi/fxjs_v8.cpp View 1 3 chunks +20 lines, -13 lines 0 comments Download
M fxjse/class.cpp View 3 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jochen (gone - plz use gerrit)
4 years, 5 months ago (2016-07-06 09:15:11 UTC) #1
haraken
non-owner LGTM
4 years, 5 months ago (2016-07-06 09:16:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123153002/20001
4 years, 5 months ago (2016-07-06 11:17:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_xfa_clang on master.tryserver.client.pdfium (JOB_FAILED, https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa_clang/builds/89)
4 years, 5 months ago (2016-07-06 11:20:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2123153002/20001
4 years, 5 months ago (2016-07-06 12:14:05 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 12:26:28 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/c4dedf32b1f5c71740df5be2a9b1446a01df...

Powered by Google App Engine
This is Rietveld 408576698