ServiceWorkerContainer should override contextDestroyed and clear m_provider

ServiceWorkerContainer should override contextDestroyed and clear m_provider

After landing https://codereview.chromium.org/2138003002/,
http/tests/serviceworkers/ tests started hitting ASSERT(!m_provider)
in ServiceWorkerContainer's destructor.
I don't really know why the CL triggered the assert, but we can fix the issue
by overriding contextDestroyed in ServiceWorkerContainer and clear m_provider there.
This CL makes the change.

BUG=

Committed: https://crrev.com/1b0b710282e282c2ce595845af90f54bd460c95d
Cr-Commit-Position: refs/heads/master@{#405486}

[haraken, 2016-07-14 09:03:52]

haraken@chromium.org changed reviewers:
+ dcheng@chromium.org, falken@chromium.org

[haraken, 2016-07-14 09:03:53]

PTAL

https://codereview.chromium.org/2144213002/diff/1/third_party/WebKit/Source/m...
File
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp
(left):

https://codereview.chromium.org/2144213002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp:192:
container->willBeDetachedFromFrame();

This is no longer needed because contextDestroyed() is called when the
DummyPageHolder is destructed at the end of the test.

[dcheng, 2016-07-14 09:20:38]

Is this just causing flaky failures on the waterfall, or were these real
consistent failures that somehow weren't being caused?

[haraken, 2016-07-14 09:24:57]

On 2016/07/14 09:20:38, dcheng wrote:
> Is this just causing flaky failures on the waterfall, or were these real
> consistent failures that somehow weren't being caused?

It's causing flaky failures on the waterfall after
https://codereview.chromium.org/2138003002/. I'm not yet sure why the CL
triggered the assert though.

[dcheng, 2016-07-14 09:39:47]

I guess service worker does some work that doesn't always run before the test is
torn down, so it's flaky.

LGTM if falken thinks this change is OK.

[falken, 2016-07-14 09:53:06]

lgtm

[haraken, 2016-07-14 09:55:14]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-14 09:55:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 11:05:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 11:05:46]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[haraken, 2016-07-14 12:49:51]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-07-14 12:50:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 14:06:48]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-14 14:06:50]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-14 14:08:39]

Description was changed from

==========
ServiceWorkerContainer should override contextDestroyed and clear m_provider

After landing https://codereview.chromium.org/2138003002/,
http/tests/serviceworkers/ tests started hitting ASSERT(!m_provider)
in ServiceWorkerContainer's destructor.
I don't really know why the CL triggered the assert, but we can fix the issue
by overriding contextDestroyed in ServiceWorkerContainer and clear m_provider
there.
This CL makes the change.

BUG=
==========

to

==========
ServiceWorkerContainer should override contextDestroyed and clear m_provider

After landing https://codereview.chromium.org/2138003002/,
http/tests/serviceworkers/ tests started hitting ASSERT(!m_provider)
in ServiceWorkerContainer's destructor.
I don't really know why the CL triggered the assert, but we can fix the issue
by overriding contextDestroyed in ServiceWorkerContainer and clear m_provider
there.
This CL makes the change.

BUG=

Committed: https://crrev.com/1b0b710282e282c2ce595845af90f54bd460c95d
Cr-Commit-Position: refs/heads/master@{#405486}
==========

[commit-bot: I haz the power, 2016-07-14 14:08:40]

Patchset 1 (id:??) landed as
https://crrev.com/1b0b710282e282c2ce595845af90f54bd460c95d
Cr-Commit-Position: refs/heads/master@{#405486}