third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp - Issue 2144213002: ServiceWorkerContainer should override contextDestroyed and clear m_provider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

Issue 2144213002: ServiceWorkerContainer should override contextDestroyed and clear m_provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

index 4dd3c93182a150d9a628185d4e51ab2c6ce50929..b47a8652bab7238b03bf66639f634b1ad922c7c0 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp

@@ -73,10 +73,7 @@ ServiceWorkerContainer* NavigatorServiceWorker::serviceWorker(LocalFrame* frame,

void NavigatorServiceWorker::contextDestroyed()

{

- if (m_serviceWorker) {

- m_serviceWorker->willBeDetachedFromFrame();

- m_serviceWorker = nullptr;

- }

+ m_serviceWorker = nullptr;

}

DEFINE_TRACE(NavigatorServiceWorker)