third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp - Issue 2144213002: ServiceWorkerContainer should override contextDestroyed and clear m_provider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 2144213002: ServiceWorkerContainer should override contextDestroyed and clear m_provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('j') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

index b0525d225c87823b99607b2a6503772289508824..c7a4522765f091666c1ac354b217fb381099e519 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

@@ -182,7 +182,7 @@ ServiceWorkerContainer::~ServiceWorkerContainer()

ASSERT(!m_provider);

}

-void ServiceWorkerContainer::willBeDetachedFromFrame()

+void ServiceWorkerContainer::contextDestroyed()

{

if (m_provider) {

m_provider->setClient(0);