Make calling SetHeader() with invalid value fatal

Make calling SetHeader() with invalid value fatal

crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
individual CR and NL as well as CRNL.

I believe that all callers of net::HttpRequestHeaders::SetHeader() and
SetHeaderIfMissing() which use user-supplied values already verify the
value with IsValidHeaderValue() first. However, to be sure, temporarily
make it a fatal error to call SetHeader() with an invalid value.

If you see a crash attributed to this CL:

1. Associate it with the bug.
2. Follow the stack flow to work out how untrusted data ended up
being passed to SetHeader().
3. Add a call to IsValidHeaderValue() at the point where the untrusted
data was introduced. A tighter check such as IsToken() may be appopriate.

BUG=627398
Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
Cr-Commit-Position: refs/heads/master@{#405702}

[Adam Rice, 2016-07-13 07:36:43]

The CQ bit was checked by ricea@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 07:37:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-13 08:48:41]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 08:48:41]

Dry run: This issue passed the CQ dry run.

[Adam Rice, 2016-07-13 09:17:05]

+mmenke for //net OWNERS.

[Adam Rice, 2016-07-15 04:06:56]

ricea@chromium.org changed reviewers:
+ mmenke@chromium.org

[Adam Rice, 2016-07-15 04:06:56]

+mmenke for real this time.

[mmenke, 2016-07-15 04:16:40]

On 2016/07/15 04:06:56, Adam Rice wrote:
> +mmenke for real this time.

LGTM

[Adam Rice, 2016-07-15 04:17:06]

The CQ bit was checked by ricea@chromium.org

[commit-bot: I haz the power, 2016-07-15 04:17:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 05:26:38]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 05:26:50]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 05:28:28]

Description was changed from

==========
Make calling SetHeader() with invalid value fatal

crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
individual CR and NL as well as CRNL.

I believe that all callers of net::HttpRequestHeaders::SetHeader() and
SetHeaderIfMissing() which use user-supplied values already verify the
value with IsValidHeaderValue() first. However, to be sure, temporarily
make it a fatal error to call SetHeader() with an invalid value.

If you see a crash attributed to this CL:

1. Associate it with the bug.
2. Follow the stack flow to work out how untrusted data ended up
being passed to SetHeader().
3. Add a call to IsValidHeaderValue() at the point where the untrusted
data was introduced. A tighter check such as IsToken() may be appopriate.

BUG=627398
==========

to

==========
Make calling SetHeader() with invalid value fatal

crrev.com/2134083003 made net::HttpUtil::IsValidHeaderValue() reject
individual CR and NL as well as CRNL.

I believe that all callers of net::HttpRequestHeaders::SetHeader() and
SetHeaderIfMissing() which use user-supplied values already verify the
value with IsValidHeaderValue() first. However, to be sure, temporarily
make it a fatal error to call SetHeader() with an invalid value.

If you see a crash attributed to this CL:

1. Associate it with the bug.
2. Follow the stack flow to work out how untrusted data ended up
being passed to SetHeader().
3. Add a call to IsValidHeaderValue() at the point where the untrusted
data was introduced. A tighter check such as IsToken() may be appopriate.

BUG=627398

Committed: https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
Cr-Commit-Position: refs/heads/master@{#405702}
==========

[commit-bot: I haz the power, 2016-07-15 05:28:29]

Patchset 1 (id:??) landed as
https://crrev.com/c5c1a790acc423f359c22641ac2ab0f3f9e6d7a9
Cr-Commit-Position: refs/heads/master@{#405702}

[Adam Rice, 2016-08-24 02:52:09]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2268423004/ by ricea@chromium.org.

The reason for reverting is: This CL has served its purpose of finding bad
callers of SetHeader() and should be reverted before the branch point..