Make calling SetHeader() with invalid value fatal

net/http/http_request_headers.cc

Index: net/http/http_request_headers.cc
diff --git a/net/http/http_request_headers.cc b/net/http/http_request_headers.cc
index c6fcaad6366e7facaffb0fdc145460db87a87b89..ec01446ef98a2cd61fad7ab0eca954041ffb53f7 100644
--- a/net/http/http_request_headers.cc
+++ b/net/http/http_request_headers.cc
@@ -90,7 +90,8 @@ void HttpRequestHeaders::Clear() {
 void HttpRequestHeaders::SetHeader(const base::StringPiece& key,
                                    const base::StringPiece& value) {
   DCHECK(HttpUtil::IsValidHeaderName(key.as_string()));
-  DCHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
+  // TODO(ricea): Revert this. See crbug.com/627398.
+  CHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
   HeaderVector::iterator it = FindHeader(key);
   if (it != headers_.end())
     it->value.assign(value.data(), value.size());
@@ -101,7 +102,8 @@ void HttpRequestHeaders::SetHeader(const base::StringPiece& key,
 void HttpRequestHeaders::SetHeaderIfMissing(const base::StringPiece& key,
                                             const base::StringPiece& value) {
   DCHECK(HttpUtil::IsValidHeaderName(key.as_string()));
-  DCHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
+  // TODO(ricea): Revert this. See crbug.com/627398.
+  CHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
   HeaderVector::iterator it = FindHeader(key);
   if (it == headers_.end())
     headers_.push_back(HeaderKeyValuePair(key, value));