Make calling SetHeader() with invalid value fatal

net/http/http_request_headers.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/http/http_request_headers.h"
 
 #include <utility>
 
 #include "base/logging.h"
 #include "base/strings/string_split.h"
@@ skipping 72 matching lines @@
   return true;
 }
 
 void HttpRequestHeaders::Clear() {
   headers_.clear();
 }
 
 void HttpRequestHeaders::SetHeader(const base::StringPiece& key,
                                    const base::StringPiece& value) {
   DCHECK(HttpUtil::IsValidHeaderName(key.as_string()));
-  DCHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
+  // TODO(ricea): Revert this. See crbug.com/627398.
+  CHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
   HeaderVector::iterator it = FindHeader(key);
   if (it != headers_.end())
     it->value.assign(value.data(), value.size());
   else
     headers_.push_back(HeaderKeyValuePair(key, value));
 }
 
 void HttpRequestHeaders::SetHeaderIfMissing(const base::StringPiece& key,
                                             const base::StringPiece& value) {
   DCHECK(HttpUtil::IsValidHeaderName(key.as_string()));
-  DCHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
+  // TODO(ricea): Revert this. See crbug.com/627398.
+  CHECK(HttpUtil::IsValidHeaderValue(value.as_string()));
   HeaderVector::iterator it = FindHeader(key);
   if (it == headers_.end())
     headers_.push_back(HeaderKeyValuePair(key, value));
 }
 
 void HttpRequestHeaders::RemoveHeader(const base::StringPiece& key) {
   HeaderVector::iterator it = FindHeader(key);
   if (it != headers_.end())
     headers_.erase(it);
 }
@@ skipping 136 matching lines @@
   for (HeaderVector::const_iterator it = headers_.begin();
        it != headers_.end(); ++it) {
     if (base::EqualsCaseInsensitiveASCII(key, it->key))
       return it;
   }
 
   return headers_.end();
 }
 
 }  // namespace net