Issue 2143893007: Remove attachment brokering from non-NaCl child processes.

Created:
4 years, 5 months ago by Anand Mistry (off Chromium)

Modified:
4 years, 5 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove attachment brokering from the browser. NOT FOR SUBMIT. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : fkgjhfjkghfkdjhgkfdjgh #

Patch Set 5 : rebase #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -100 lines)			Patch
M	components/nacl/broker/nacl_broker_listener.cc	View	1 4	3 chunks	+0 lines, -8 lines	0 comments	Download
M	components/nacl/loader/nacl_listener.cc	View	1 4	3 chunks	+0 lines, -5 lines	0 comments	Download
M	content/browser/browser_child_process_host_impl.cc	View	1	2 chunks	+0 lines, -15 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View	1 2 3 4	6 chunks	+0 lines, -32 lines	0 comments	Download
M	content/child/child_thread_impl.cc	View	1 2 3 4	4 chunks	+0 lines, -11 lines	0 comments	Download
M	content/common/child_process_host_impl.cc	View	2	4 chunks	+1 line, -29 lines	0 comments	Download

Depends on Patchset:

Issue 2168523002 Patch 20001

Messages

Total messages: 25 (24 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Anand Mistry (off Chromium)

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

4 years, 5 months ago (2016-07-15 01:32:28 UTC) #1

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143893007/1

4 years, 5 months ago (2016-07-15 01:32:56 UTC) #2

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

Anand Mistry (off Chromium)

Description was changed from ========== Remove attachment brokering from non-NaCl child processes. NOT FOR SUBMIT. ...

4 years, 5 months ago (2016-07-15 02:50:05 UTC) #3

Description was changed from

==========
Remove attachment brokering from non-NaCl child processes.

NOT FOR SUBMIT.
==========

to

==========
Remove attachment brokering from the browser.

NOT FOR SUBMIT.

BUG=
==========

Anand Mistry (off Chromium)

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

4 years, 5 months ago (2016-07-15 02:50:42 UTC) #4

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143893007/20001

4 years, 5 months ago (2016-07-15 02:51:20 UTC) #5

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 5 months ago (2016-07-15 02:53:41 UTC) #6

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/36247) ios-device-gn on ...

4 years, 5 months ago (2016-07-15 02:53:42 UTC) #7

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

Anand Mistry (off Chromium)

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

4 years, 5 months ago (2016-07-15 03:11:05 UTC) #8

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143893007/40001

4 years, 5 months ago (2016-07-15 03:11:20 UTC) #9

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 5 months ago (2016-07-15 03:13:17 UTC) #10

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

4 years, 5 months ago (2016-07-15 03:13:18 UTC) #11

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Anand Mistry (off Chromium)

Description was changed from ========== Remove attachment brokering from the browser. NOT FOR SUBMIT. BUG= ...

4 years, 5 months ago (2016-07-15 03:35:46 UTC) #12

Description was changed from

==========
Remove attachment brokering from the browser.

NOT FOR SUBMIT.

BUG=
==========

to

==========
Remove attachment brokering from the browser.

NOT FOR SUBMIT.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Anand Mistry (off Chromium)

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

4 years, 5 months ago (2016-07-15 03:35:56 UTC) #13

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143893007/60001

4 years, 5 months ago (2016-07-15 03:36:09 UTC) #14

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 5 months ago (2016-07-15 04:05:26 UTC) #15

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/260616)

4 years, 5 months ago (2016-07-15 04:05:27 UTC) #16

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Anand Mistry (off Chromium)

rebase

4 years, 5 months ago (2016-07-21 01:27:00 UTC) #17

rebase

Anand Mistry (off Chromium)

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

4 years, 5 months ago (2016-07-21 01:27:06 UTC) #18

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143893007/80001

4 years, 5 months ago (2016-07-21 01:27:36 UTC) #19

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 5 months ago (2016-07-21 01:52:14 UTC) #20

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/204879)

4 years, 5 months ago (2016-07-21 01:52:14 UTC) #21

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Anand Mistry (off Chromium)

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

4 years, 5 months ago (2016-07-21 11:31:37 UTC) #22

The CQ bit was checked by amistry@chromium.org to run a CQ dry run

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143893007/80001

4 years, 5 months ago (2016-07-21 11:31:54 UTC) #23

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 5 months ago (2016-07-21 11:53:52 UTC) #24

The CQ bit was unchecked by commit-bot@chromium.org

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/194403)

4 years, 5 months ago (2016-07-21 11:53:53 UTC) #25

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages