Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 2143893007: Remove attachment brokering from non-NaCl child processes. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/browser_child_process_host_impl.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_process_host_impl.cc
diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc
index 5393ddeadf53ba966cd853fcad27eff4eae8da96..b0d88a13e6dd0c9e200cac77d0bfbe965f53cb32 100644
--- a/content/browser/renderer_host/render_process_host_impl.cc
+++ b/content/browser/renderer_host/render_process_host_impl.cc
@@ -161,8 +161,6 @@
#include "gpu/command_buffer/client/gpu_switches.h"
#include "gpu/command_buffer/common/gles2_cmd_utils.h"
#include "gpu/command_buffer/service/gpu_switches.h"
-#include "ipc/attachment_broker.h"
-#include "ipc/attachment_broker_privileged.h"
#include "ipc/ipc_channel.h"
#include "ipc/ipc_channel_mojo.h"
#include "ipc/ipc_logging.h"
@@ -601,19 +599,6 @@ RenderProcessHostImpl::RenderProcessHostImpl(
AddObserver(BootstrapSandboxManager::GetInstance());
#endif
-#if USE_ATTACHMENT_BROKER
- // Construct the privileged attachment broker early in the life cycle of a
- // render process. This ensures that when a test is being run in one of the
- // single process modes, the global attachment broker is the privileged
- // attachment broker, rather than an unprivileged attachment broker.
-#if defined(OS_MACOSX)
- IPC::AttachmentBrokerPrivileged::CreateBrokerIfNeeded(
- MachBroker::GetInstance());
-#else
- IPC::AttachmentBrokerPrivileged::CreateBrokerIfNeeded();
-#endif // defined(OS_MACOSX)
-#endif // USE_ATTACHMENT_BROKER
-
scoped_refptr<base::SequencedTaskRunner> io_task_runner =
BrowserThread::GetTaskRunnerForThread(BrowserThread::IO);
shell::Connector* connector =
@@ -684,10 +669,6 @@ RenderProcessHostImpl::~RenderProcessHostImpl() {
gpu_observer_registered_ = false;
}
-#if USE_ATTACHMENT_BROKER
- IPC::AttachmentBroker::GetGlobal()->DeregisterCommunicationChannel(
- channel_.get());
-#endif
// We may have some unsent messages at this point, but that's OK.
channel_.reset();
while (!queued_messages_.empty()) {
@@ -857,10 +838,6 @@ std::unique_ptr<IPC::ChannelProxy> RenderProcessHostImpl::CreateChannelProxy(
std::unique_ptr<IPC::ChannelProxy> channel(
new IPC::ChannelProxy(this, runner.get()));
-#if USE_ATTACHMENT_BROKER
- IPC::AttachmentBroker::GetGlobal()->RegisterCommunicationChannel(
- channel.get(), runner);
-#endif
channel->Init(std::move(channel_factory), true);
return channel;
}
@@ -1952,11 +1929,6 @@ void RenderProcessHostImpl::Cleanup() {
base::ThreadTaskRunnerHandle::Get()->DeleteSoon(FROM_HERE, this);
deleting_soon_ = true;
-#if USE_ATTACHMENT_BROKER
- IPC::AttachmentBroker::GetGlobal()->DeregisterCommunicationChannel(
- channel_.get());
-#endif
-
// It's important not to wait for the DeleteTask to delete the channel
// proxy. Kill it off now. That way, in case the profile is going away, the
// rest of the objects attached to this RenderProcessHost start going
@@ -2450,10 +2422,6 @@ void RenderProcessHostImpl::ProcessDied(bool already_dead,
RendererClosedDetails details(status, exit_code);
child_process_launcher_.reset();
-#if USE_ATTACHMENT_BROKER
- IPC::AttachmentBroker::GetGlobal()->DeregisterCommunicationChannel(
- channel_.get());
-#endif
channel_.reset();
while (!queued_messages_.empty()) {
delete queued_messages_.front();
« no previous file with comments | « content/browser/browser_child_process_host_impl.cc ('k') | content/child/child_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698