Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Unified Diff: components/nacl/broker/nacl_broker_listener.cc

Issue 2143893007: Remove attachment brokering from non-NaCl child processes. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/broker/nacl_broker_listener.cc
diff --git a/components/nacl/broker/nacl_broker_listener.cc b/components/nacl/broker/nacl_broker_listener.cc
index 69a58fd8ddfdc568e110c1009d7d361ad78200a3..3a7a06b005106351006c9715348503b5587e5cee 100644
--- a/components/nacl/broker/nacl_broker_listener.cc
+++ b/components/nacl/broker/nacl_broker_listener.cc
@@ -22,7 +22,6 @@
#include "content/public/common/content_switches.h"
#include "content/public/common/mojo_channel_switches.h"
#include "content/public/common/sandbox_init.h"
-#include "ipc/attachment_broker_unprivileged.h"
#include "ipc/ipc_channel.h"
#include "ipc/ipc_switches.h"
#include "mojo/edk/embedder/embedder.h"
@@ -39,13 +38,9 @@ void SendReply(IPC::Channel* channel, int32_t pid, bool result) {
} // namespace
NaClBrokerListener::NaClBrokerListener() {
- IPC::AttachmentBrokerUnprivileged::CreateBrokerIfNeeded();
}
NaClBrokerListener::~NaClBrokerListener() {
- IPC::AttachmentBroker* broker = IPC::AttachmentBroker::GetGlobal();
- if (broker && !broker->IsPrivilegedBroker() && channel_)
- broker->DeregisterBrokerCommunicationChannel(channel_.get());
}
void NaClBrokerListener::Listen() {
@@ -57,9 +52,6 @@ void NaClBrokerListener::Listen() {
IPC::ChannelHandle channel_handle(handle.release());
channel_ = IPC::Channel::CreateClient(channel_handle, this);
- IPC::AttachmentBroker* broker = IPC::AttachmentBroker::GetGlobal();
- if (broker && !broker->IsPrivilegedBroker())
- broker->RegisterBrokerCommunicationChannel(channel_.get());
CHECK(channel_->Connect());
base::MessageLoop::current()->Run();
}
« no previous file with comments | « no previous file | components/nacl/loader/nacl_listener.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698