Issue 2143893003: Fix how revision_cp is obtained in chromedriver recipe.

Issue 2143893003: Fix how revision_cp is obtained in chromedriver recipe. (Closed)

Created:
4 years, 5 months ago by mikecase (-- gone --)

Modified:
4 years, 5 months ago

Reviewers:
jbudorick, martiniss

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, samuong

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -4 lines)			Patch
M	scripts/slave/recipes/chromedriver.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json	View	1 chunk	+1 line, -1 line	0 comments	Download
M	scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 9 (4 generated)

mikecase (-- gone --)

Do you know the correct way to get got_revision_cp property in a recipe. The old ...

4 years, 5 months ago (2016-07-13 17:19:14 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143893003/1

4 years, 5 months ago (2016-07-13 21:24:43 UTC) #7

commit-bot: I haz the power

4 years, 5 months ago (2016-07-13 21:29:18 UTC) #9

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/216e1a70fb807ef26a93...