Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Side by Side Diff: scripts/slave/recipes/chromedriver.py

Issue 2143893003: Fix how revision_cp is obtained in chromedriver recipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine import recipe_api 5 from recipe_engine import recipe_api
6 from recipe_engine.types import freeze 6 from recipe_engine.types import freeze
7 7
8 DEPS = [ 8 DEPS = [
9 'adb', 9 'adb',
10 'archive', 10 'archive',
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 api.bot_update.ensure_checkout() 61 api.bot_update.ensure_checkout()
62 api.chromium_android.clean_local_files() 62 api.chromium_android.clean_local_files()
63 api.chromium.runhooks() 63 api.chromium.runhooks()
64 api.chromium_android.run_tree_truth() 64 api.chromium_android.run_tree_truth()
65 65
66 api.archive.download_and_unzip_build( 66 api.archive.download_and_unzip_build(
67 step_name='extract build', 67 step_name='extract build',
68 target=api.chromium.c.BUILD_CONFIG, 68 target=api.chromium.c.BUILD_CONFIG,
69 build_url=None, 69 build_url=None,
70 build_archive_url=api.properties.get('parent_build_archive_url')) 70 build_archive_url=api.properties.get('parent_build_archive_url'))
71 commit_position = api.commit_position.parse_revision( 71 revision_cp = api.bot_update.last_returned_properties['got_revision_cp']
72 api.properties['got_revision_cp']) 72 commit_position = api.commit_position.parse_revision(revision_cp)
73 73
74 api.chromium_android.common_tests_setup_steps() 74 api.chromium_android.common_tests_setup_steps()
75 if builder['install_apks']: 75 if builder['install_apks']:
76 for apk in builder['install_apks']: 76 for apk in builder['install_apks']:
77 api.chromium_android.adb_install_apk(apk) 77 api.chromium_android.adb_install_apk(apk)
78 api.chromedriver.download_prebuilts() 78 api.chromedriver.download_prebuilts()
79 79
80 passed = True 80 passed = True
81 try: 81 try:
82 api.chromedriver.run_all_tests( 82 api.chromedriver.run_all_tests(
(...skipping 25 matching lines...) Expand all
108 '%s_test_failure' % sanitize('Android ChromeDriver Tests (dbg)')) + 108 '%s_test_failure' % sanitize('Android ChromeDriver Tests (dbg)')) +
109 api.properties.generic( 109 api.properties.generic(
110 buildername='Android ChromeDriver Tests (dbg)', 110 buildername='Android ChromeDriver Tests (dbg)',
111 slavename='slavename', 111 slavename='slavename',
112 mastername='chromium.fyi') + 112 mastername='chromium.fyi') +
113 api.properties( 113 api.properties(
114 parent_build_archive_url='gs://test-domain/test-archive.zip', 114 parent_build_archive_url='gs://test-domain/test-archive.zip',
115 got_revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00', 115 got_revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00',
116 got_revision_cp='refs/heads/master@{#333333}') + 116 got_revision_cp='refs/heads/master@{#333333}') +
117 api.step_data('java_tests(chrome_stable)', retcode=1)) 117 api.step_data('java_tests(chrome_stable)', retcode=1))
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698