scripts/slave/recipes/chromedriver.py - Issue 2143893003: Fix how revision_cp is obtained in chromedriver recipe.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/chromedriver.py

Issue 2143893003: Fix how revision_cp is obtained in chromedriver recipe. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/chromedriver.py

diff --git a/scripts/slave/recipes/chromedriver.py b/scripts/slave/recipes/chromedriver.py

index 03178aebb9bcba958bf986a70bc3b94377527cd7..7ce9c0177af4b740e137e58fa169e45a38d5bc10 100644

--- a/scripts/slave/recipes/chromedriver.py

+++ b/scripts/slave/recipes/chromedriver.py

@@ -68,8 +68,8 @@ def RunSteps(api):

target=api.chromium.c.BUILD_CONFIG,

build_url=None,

build_archive_url=api.properties.get('parent_build_archive_url'))

- commit_position = api.commit_position.parse_revision(

- api.properties['got_revision_cp'])

+ revision_cp = api.bot_update.last_returned_properties['got_revision_cp']

+ commit_position = api.commit_position.parse_revision(revision_cp)

api.chromium_android.common_tests_setup_steps()

if builder['install_apks']:

« no previous file with comments | « no previous file | scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json » ('j') | no next file with comments »