Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2143503002: Switch chromedriver to new recipe, remove bb_run_bot references from build/. (Closed)

Created:
4 years, 5 months ago by ghost stip (do not use)
Modified:
4 years, 5 months ago
CC:
bpastene, chromium-reviews, infra-reviews+build_chromium.org, jbudorick, kjellander-cc_chromium.org, gmanikpure
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Switch chromedriver to new recipe, remove bb_run_bot references from build/. BUG=598907, 619045 Committed: https://chromium.googlesource.com/chromium/tools/build/+/8d17b9874ec74054e26e9bb273f27da529379baf

Patch Set 1 #

Messages

Total messages: 13 (5 generated)
ghost stip (do not use)
ptal. This finalizes the work done in https://codereview.chromium.org/1274723004/. This will need a chromium.fyi restart, and ...
4 years, 5 months ago (2016-07-11 23:26:41 UTC) #2
ghost stip (do not use)
(actually cc bpastene@ this time)
4 years, 5 months ago (2016-07-11 23:28:11 UTC) #4
Ken Russell (switch to Gerrit)
lgtm. Those recipes should be completely unreferenced at this point. Thanks for the cleanup.
4 years, 5 months ago (2016-07-11 23:37:39 UTC) #5
mikecase (-- gone --)
lgtm, but please wait to land this till tomorrow morning so I can keep an ...
4 years, 5 months ago (2016-07-12 00:04:31 UTC) #7
ghost stip (do not use)
ok, sg
4 years, 5 months ago (2016-07-12 00:06:10 UTC) #8
samuong
lgtm
4 years, 5 months ago (2016-07-12 17:35:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143503002/1
4 years, 5 months ago (2016-07-12 17:49:07 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-12 17:53:23 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/8d17b9874ec74054e26e...

Powered by Google App Engine
This is Rietveld 408576698