Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1582)

Unified Diff: scripts/master/recipe_converter.py

Issue 2143503002: Switch chromedriver to new recipe, remove bb_run_bot references from build/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/master/recipe_converter.py
diff --git a/scripts/master/recipe_converter.py b/scripts/master/recipe_converter.py
index f79f8e853a30cb4c9a76b490d441bdcdae754b10..ef1f8333f2b9b06e5d4ae62579c926590c86ae3b 100755
--- a/scripts/master/recipe_converter.py
+++ b/scripts/master/recipe_converter.py
@@ -212,14 +212,6 @@ _step_signatures = {
'workdir': 'build',
}
),
- 'bb_run_bot': (master.chromium_step.AnnotatedCommand,
- {
- 'command': ['python',
- 'src/build/android/buildbot/bb_run_bot.py'],
- 'name': 'slave_steps',
- 'description': 'slave_steps',
- }
- ),
'gclient_runhooks_wrapper': (buildbot.steps.shell.ShellCommand,
{
'command': ['python', '../../../scripts/slave/runhooks_wrapper.py'],
@@ -1623,19 +1615,6 @@ def bot_update_converter(step):
# that is why it is ignored here. (aneeshm)
return rc
-def bb_run_bot_converter(step):
- rc = recipe_chunk()
- rc.steps.append('# slave_steps step')
- rc.deps.add('recipe_engine/python')
- rc.deps.add('recipe_engine/json')
- build_properties = "'--build-properties=%s' % " +\
- "api.json.dumps(build_properties, separators=(',', ':'))"
- fmtstr = 'api.python("slave_steps", "%s", args=[%s, \'%s\'],' +\
- ' allow_subannotations=True)'
- rc.steps.append(fmtstr % (step[1]['command'][1], build_properties,
- step[1]['command'][3]))
- return rc
-
def gclient_runhooks_wrapper_converter(step):
rc = recipe_chunk()
rc.deps.add('recipe_engine/python')
@@ -1724,7 +1703,6 @@ _step_converters_map = {
'gclient_update': gclient_update_converter,
'bot_update': bot_update_converter,
'win_bot_update': bot_update_converter,
- 'bb_run_bot': bb_run_bot_converter,
'gclient_runhooks_wrapper': gclient_runhooks_wrapper_converter,
'win_gclient_runhooks_wrapper': gclient_runhooks_wrapper_converter,
'chromedriver_buildbot_run': chromedriver_buildbot_run_converter,
« no previous file with comments | « masters/master.chromium.fyi/master.cfg ('k') | scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698