Switch chromedriver to new recipe, remove bb_run_bot references from build/.

scripts/master/recipe_converter.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import master.chromium_step
 import master.log_parser.retcode_command
 import master.log_parser.webkit_test_command
 import master.factory.commands
 import master.factory.drmemory_factory
 import master.master_utils
@@ skipping 194 matching lines @@
   'win_gclient_safe_revert': (buildbot.steps.shell.ShellCommand,
       {
         'command': ['python_slave',
           '..\\..\\..\\scripts\\slave\\gclient_safe_revert.py',
           '.', 'gclient.bat'],
         'description': 'gclient_revert',
         'name': 'gclient_revert',
         'workdir': 'build',
       }
     ),
-  'bb_run_bot':   (master.chromium_step.AnnotatedCommand,
-                   {
-                     'command': ['python',
-                       'src/build/android/buildbot/bb_run_bot.py'],
-                     'name': 'slave_steps',
-                     'description': 'slave_steps',
-                   }
-                  ),
   'gclient_runhooks_wrapper': (buildbot.steps.shell.ShellCommand,
       {
         'command': ['python', '../../../scripts/slave/runhooks_wrapper.py'],
         'description': 'gclient hooks',
         'env': {},
         'name': 'runhooks'
         # NOTE: locking shouldn't be required, as only one recipe is ever run on
         # a slave at a time; specifically, a SlaveLock of type slave_exclusive
         # *should be* redundant. Noted here in case it isn't. (aneeshm)
       }
@@ skipping 1383 matching lines @@
   rc.steps.append('api.gclient.c = src_cfg')
   # Then, call bot_update on it.
   rc.steps.append('result = api.bot_update.ensure_checkout(force=True)')
   rc.steps.append(
       'build_properties.update(result.json.output.get("properties", {}))')
   # NOTE: wherever there is a gclient_runhooks steps after bot_update (which
   # *should* be everywhere), the '--gyp_env' argument need not be passed in;
   # that is why it is ignored here. (aneeshm)
   return rc
 
-def bb_run_bot_converter(step):
-  rc = recipe_chunk()
-  rc.steps.append('# slave_steps step')
-  rc.deps.add('recipe_engine/python')
-  rc.deps.add('recipe_engine/json')
-  build_properties = "'--build-properties=%s' % " +\
-      "api.json.dumps(build_properties, separators=(',', ':'))"
-  fmtstr = 'api.python("slave_steps", "%s", args=[%s, \'%s\'],' +\
-      ' allow_subannotations=True)'
-  rc.steps.append(fmtstr % (step[1]['command'][1], build_properties,
-                            step[1]['command'][3]))
-  return rc
-
 def gclient_runhooks_wrapper_converter(step):
   rc = recipe_chunk()
   rc.deps.add('recipe_engine/python')
   rc.deps.add('recipe_engine/path')
   rc.steps.append('# gclient runhooks wrapper step')
   rc.steps.append('env = %s' % repr(step[1]['env']))
   rc.steps.append('api.python("gclient runhooks wrapper", ' +\
       'api.path["build"].join("scripts", "slave", "runhooks_wrapper.py"), '+\
       'env=env)')
   return rc
@@ skipping 68 matching lines @@
 
 _step_converters_map = {
     'cleanup_temp': cleanup_temp_converter,
     'win_cleanup_temp': cleanup_temp_converter,
     'update_scripts': update_scripts_converter,
     'gclient_safe_revert': gclient_safe_revert_converter,
     'win_gclient_safe_revert': gclient_safe_revert_converter,
     'gclient_update': gclient_update_converter,
     'bot_update': bot_update_converter,
     'win_bot_update': bot_update_converter,
-    'bb_run_bot': bb_run_bot_converter,
     'gclient_runhooks_wrapper': gclient_runhooks_wrapper_converter,
     'win_gclient_runhooks_wrapper': gclient_runhooks_wrapper_converter,
     'chromedriver_buildbot_run': chromedriver_buildbot_run_converter,
     'win_chromedriver_buildbot_run': win_chromedriver_buildbot_run_converter,
     'compile_py': compile_py_converter,
     'win_compile_py': win_compile_py_converter,
     'win_svnkill': win_svnkill_converter,
     'win_update_scripts': update_scripts_converter,
     'win_taskkill': win_taskkill_converter,
     'runtest': runtest_converter,
@@ skipping 414 matching lines @@
     print >> f, ">>> Converted"
     print >> f, step_to_recipe_chunk(step)
 
 def write_numsteps_builder(c, buildername, filename):
   with open(filename, 'w') as f:
     f.write(str(len(extract_builder_steplist(c, buildername))))
 
 def write_builder_steplist(c, builder_name, filename):
   with open(filename, 'w') as f:
     f.write(pprint.pformat(extract_builder_steplist(c, builder_name), indent=2))