Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2143423002: Reland of WebGL: use storage texture for DrawingBuffer only if CMAA is enabled. (Closed)

Created:
4 years, 5 months ago by dshwang
Modified:
4 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of WebGL: use storage texture for DrawingBuffer only if CMAA is enabled. (patchset #1 id:1 of https://codereview.chromium.org/2133253003/ ) Reason for revert: ATI bot failed due to this CL. ATI bot was fine because we disabled WebglConformance.conformance_textures_misc_tex_image_webgl However, https://codereview.chromium.org/2141893002/ enabled the test again, so this CL must be reverted. Original issue's description: > Revert of WebGL: use storage texture for DrawingBuffer only if CMAA is enabled. (patchset #3 id:60001 of https://codereview.chromium.org/2131863003/ ) > > Reason for revert: > ATI GPU bots became green, no matter this CL. ATI GPU bot might be in bad shape for some reasons. > So revert this redundant speculative fix. > > Original issue's description: > > WebGL: use storage texture for DrawingBuffer only if CMAA is enabled. > > > > It's because Linux ATI bot fails > > WebglConformance.conformance_textures_misc_tex_image_webgl > > When finding the solution for ATI driver, rollback this patch. > > > > BUG=557848 > > TEST=WebglConformance.conformance_textures_misc_tex_image_webgl > > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel > > > > Committed: https://crrev.com/65f8f6c737278a80acee2bcd407d1fdc15426fa8 > > Cr-Commit-Position: refs/heads/master@{#404514} > > TBR=piman@chromium.org,kbr@chromium.org,zmo@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=557848 > > Committed: https://crrev.com/e33a44a7077c60edfa28bc0d79b0910ab43d58d1 > Cr-Commit-Position: refs/heads/master@{#404563} TBR=piman@chromium.org,kbr@chromium.org,zmo@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=557848 Committed: https://crrev.com/5de5bf320abfd923cbeb5a11b832eb81c9952bde Cr-Commit-Position: refs/heads/master@{#405131}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
dshwang
Created Reland of WebGL: use storage texture for DrawingBuffer only if CMAA is enabled.
4 years, 5 months ago (2016-07-13 11:46:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143423002/1
4 years, 5 months ago (2016-07-13 11:46:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-13 12:50:58 UTC) #5
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 12:51:02 UTC) #6
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 12:52:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5de5bf320abfd923cbeb5a11b832eb81c9952bde
Cr-Commit-Position: refs/heads/master@{#405131}

Powered by Google App Engine
This is Rietveld 408576698