Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2141893002:
WebGL: enable conformance/textures/misc/tex-image-webgl.html (Closed)
DescriptionWebGL: enable conformance/textures/misc/tex-image-webgl.html
We found https://codereview.chromium.org/2131863003/ causes this failure.
As we can fix the root issue, enable it again.
BUG=626742
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true
Committed: https://crrev.com/17bc1818c93d77c43fa0613008c5554a55b34438
Cr-Commit-Position: refs/heads/master@{#404856}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
Description was changed from ========== WebGL: enable conformance/textures/misc/tex-image-webgl.html We found https://codereview.chromium.org/2131863003/ causes this failure. As we can fix the root issue, enable it again. BUG=626742 ========== to ========== WebGL: enable conformance/textures/misc/tex-image-webgl.html We found https://codereview.chromium.org/2131863003/ causes this failure. As we can fix the root issue, enable it again. BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
dongseong.hwang@intel.com changed reviewers: + kbr@chromium.org, zmo@chromium.org
Enable the test as Ken suggested in https://codereview.chromium.org/2131863003/ Could you review?
On 2016/07/12 08:58:31, dshwang wrote: > Enable the test as Ken suggested in https://codereview.chromium.org/2131863003/ > Could you review? submit new CL instead of revert https://codereview.chromium.org/2134643004, because the CL disables two different tests.
On 2016/07/12 08:59:30, dshwang wrote: > On 2016/07/12 08:58:31, dshwang wrote: > > Enable the test as Ken suggested in > https://codereview.chromium.org/2131863003/ > > Could you review? > > submit new CL instead of revert https://codereview.chromium.org/2134643004, > because the CL disables two different tests. lgtm
lgtm too
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/07/12 20:47:48, commit-bot: I haz the power wrote: > Try jobs failed on following builders: > linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, > http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) There was an outage on these tryservers. Rather than waste cycles going through the CQ again I'm committing this NOTRY=true.
Description was changed from ========== WebGL: enable conformance/textures/misc/tex-image-webgl.html We found https://codereview.chromium.org/2131863003/ causes this failure. As we can fix the root issue, enable it again. BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== WebGL: enable conformance/textures/misc/tex-image-webgl.html We found https://codereview.chromium.org/2131863003/ causes this failure. As we can fix the root issue, enable it again. BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ==========
The CQ bit was checked by kbr@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== WebGL: enable conformance/textures/misc/tex-image-webgl.html We found https://codereview.chromium.org/2131863003/ causes this failure. As we can fix the root issue, enable it again. BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ========== to ========== WebGL: enable conformance/textures/misc/tex-image-webgl.html We found https://codereview.chromium.org/2131863003/ causes this failure. As we can fix the root issue, enable it again. BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== WebGL: enable conformance/textures/misc/tex-image-webgl.html We found https://codereview.chromium.org/2131863003/ causes this failure. As we can fix the root issue, enable it again. BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true ========== to ========== WebGL: enable conformance/textures/misc/tex-image-webgl.html We found https://codereview.chromium.org/2131863003/ causes this failure. As we can fix the root issue, enable it again. BUG=626742 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel NOTRY=true Committed: https://crrev.com/17bc1818c93d77c43fa0613008c5554a55b34438 Cr-Commit-Position: refs/heads/master@{#404856} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/17bc1818c93d77c43fa0613008c5554a55b34438 Cr-Commit-Position: refs/heads/master@{#404856} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
