Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2143323003: Revert of SkSL performance improvements (Closed)

Created:
4 years, 5 months ago by msarett
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of SkSL performance improvements (patchset #6 id:140001 of https://codereview.chromium.org/2131223002/ ) Reason for revert: Valgrind bot failures https://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind/builds/1224/steps/test_skia%20on%20Ubuntu/logs/stdio Original issue's description: > SkSL performance improvements (plus a couple of minor warning fixes) > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2131223002 > > Committed: https://skia.googlesource.com/skia/+/9fd67a1f53809f5eff1210dd107241b450c48acc TBR=benjaminwagner@google.com,egdaniel@google.com,ethannicholas@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://skia.googlesource.com/skia/+/e92badc3ffce83668f76fcfa33a49784346cab1e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+887 lines, -913 lines) Patch
M src/gpu/vk/GrVkPipelineStateBuilder.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M src/sksl/SkSLCompiler.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M src/sksl/SkSLIRGenerator.h View 2 chunks +8 lines, -7 lines 0 comments Download
M src/sksl/SkSLIRGenerator.cpp View 39 chunks +254 lines, -250 lines 0 comments Download
M src/sksl/SkSLParser.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M src/sksl/SkSLSPIRVCodeGenerator.h View 3 chunks +10 lines, -10 lines 0 comments Download
M src/sksl/SkSLSPIRVCodeGenerator.cpp View 59 chunks +172 lines, -177 lines 0 comments Download
M src/sksl/ir/SkSLBinaryExpression.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/ir/SkSLBlock.h View 3 chunks +2 lines, -6 lines 0 comments Download
M src/sksl/ir/SkSLBoolLiteral.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/ir/SkSLConstructor.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/sksl/ir/SkSLExpression.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/sksl/ir/SkSLField.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/sksl/ir/SkSLFieldAccess.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sksl/ir/SkSLFloatLiteral.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/ir/SkSLForStatement.h View 3 chunks +2 lines, -5 lines 0 comments Download
M src/sksl/ir/SkSLFunctionCall.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/sksl/ir/SkSLFunctionDeclaration.h View 3 chunks +8 lines, -19 lines 0 comments Download
M src/sksl/ir/SkSLFunctionDefinition.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/sksl/ir/SkSLFunctionReference.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/sksl/ir/SkSLIndexExpression.h View 2 chunks +11 lines, -11 lines 0 comments Download
M src/sksl/ir/SkSLIntLiteral.h View 1 chunk +1 line, -1 line 0 comments Download
M src/sksl/ir/SkSLInterfaceBlock.h View 1 chunk +7 lines, -9 lines 0 comments Download
M src/sksl/ir/SkSLProgram.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/sksl/ir/SkSLSwizzle.h View 1 chunk +23 lines, -22 lines 0 comments Download
M src/sksl/ir/SkSLSymbolTable.h View 2 chunks +6 lines, -13 lines 0 comments Download
M src/sksl/ir/SkSLSymbolTable.cpp View 4 chunks +33 lines, -48 lines 0 comments Download
M src/sksl/ir/SkSLType.h View 12 chunks +117 lines, -117 lines 0 comments Download
M src/sksl/ir/SkSLType.cpp View 6 chunks +160 lines, -150 lines 0 comments Download
M src/sksl/ir/SkSLTypeReference.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/sksl/ir/SkSLUnresolvedFunction.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/sksl/ir/SkSLVarDeclaration.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/sksl/ir/SkSLVariable.h View 3 chunks +14 lines, -3 lines 0 comments Download
M src/sksl/ir/SkSLVariableReference.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
msarett
Created Revert of SkSL performance improvements
4 years, 5 months ago (2016-07-13 19:51:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2143323003/1
4 years, 5 months ago (2016-07-13 19:51:28 UTC) #3
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 20:18:46 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e92badc3ffce83668f76fcfa33a49784346cab1e

Powered by Google App Engine
This is Rietveld 408576698