Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: src/sksl/ir/SkSLInterfaceBlock.h

Issue 2143323003: Revert of SkSL performance improvements (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/sksl/ir/SkSLIntLiteral.h ('k') | src/sksl/ir/SkSLProgram.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/sksl/ir/SkSLInterfaceBlock.h
diff --git a/src/sksl/ir/SkSLInterfaceBlock.h b/src/sksl/ir/SkSLInterfaceBlock.h
index f1121ed707681a8ddbc841e784cc811754730be8..baedb5864c1f5e231e401aded5d72a16c683e99d 100644
--- a/src/sksl/ir/SkSLInterfaceBlock.h
+++ b/src/sksl/ir/SkSLInterfaceBlock.h
@@ -24,24 +24,22 @@
* At the IR level, this is represented by a single variable of struct type.
*/
struct InterfaceBlock : public ProgramElement {
- InterfaceBlock(Position position, const Variable& var, std::shared_ptr<SymbolTable> typeOwner)
+ InterfaceBlock(Position position, std::shared_ptr<Variable> var)
: INHERITED(position, kInterfaceBlock_Kind)
- , fVariable(std::move(var))
- , fTypeOwner(typeOwner) {
- ASSERT(fVariable.fType.kind() == Type::kStruct_Kind);
+ , fVariable(std::move(var)) {
+ ASSERT(fVariable->fType->kind() == Type::kStruct_Kind);
}
std::string description() const override {
- std::string result = fVariable.fModifiers.description() + fVariable.fName + " {\n";
- for (size_t i = 0; i < fVariable.fType.fields().size(); i++) {
- result += fVariable.fType.fields()[i].description() + "\n";
+ std::string result = fVariable->fModifiers.description() + fVariable->fName + " {\n";
+ for (size_t i = 0; i < fVariable->fType->fields().size(); i++) {
+ result += fVariable->fType->fields()[i].description() + "\n";
}
result += "};";
return result;
}
- const Variable& fVariable;
- const std::shared_ptr<SymbolTable> fTypeOwner;
+ const std::shared_ptr<Variable> fVariable;
typedef ProgramElement INHERITED;
};
« no previous file with comments | « src/sksl/ir/SkSLIntLiteral.h ('k') | src/sksl/ir/SkSLProgram.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698