Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in DocumentMarkerController.

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in DocumentMarkerController.

BUG=590369
R=yosin,esprehn

Committed: https://crrev.com/f049582fdaef7b6168058a404a1b8519d3c570f5
Cr-Commit-Position: refs/heads/master@{#408741}

[dglazkov, 2016-07-12 21:30:32]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 21:35:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 22:55:50]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 22:55:51]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dglazkov, 2016-07-13 21:44:28]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-13 21:45:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2016-07-13 23:28:55]

Still WIP, comments for myself...

https://codereview.chromium.org/2142903003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp
(right):

https://codereview.chromium.org/2142903003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp:577:
document().updateStyleAndLayoutIgnorePendingStylesheets();
This one is tricky. Should go up, but will probably get stuck in commands.
Basically, some commands are built in a way that force pipeline flushing at
least once.

https://codereview.chromium.org/2142903003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp (right):

https://codereview.chromium.org/2142903003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:308: //
TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to
be audited.
This method should not modify the tree (need to assert this somehow), so all
these calls move up to Editor::executeCommand, the showSpellingGuessPanel
function needs to be broken up (show + hide instead of toggle) and then it can
move up to Editor::executeCommand as well.

https://codereview.chromium.org/2142903003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp:633: // see
http://crbug.com/590369 for more details.
This one and below can move up all the way up to SpellCheckRequester::didCheck.
This function really needs to have a readonly and writeonly section.

[commit-bot: I haz the power, 2016-07-14 01:36:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 01:36:04]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-07-29 18:34:55]

Now with cool scope thingy.

[dglazkov, 2016-07-29 18:34:56]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-29 18:35:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2016-07-29 19:41:12]

PTAL, should be all green (fingers crossed).

[commit-bot: I haz the power, 2016-07-29 19:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-29 19:59:43]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-07-29 20:00:04]

lgtm

[dglazkov, 2016-07-29 20:09:32]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2016-07-29 20:10:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-29 21:05:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-29 21:07:05]

Description was changed from

==========
Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in
DocumentMarkerController.

BUG=590369
R=yosin,esprehn
==========

to

==========
Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in
DocumentMarkerController.

BUG=590369
R=yosin,esprehn

Committed: https://crrev.com/f049582fdaef7b6168058a404a1b8519d3c570f5
Cr-Commit-Position: refs/heads/master@{#408741}
==========

[commit-bot: I haz the power, 2016-07-29 21:07:06]

Patchset 2 (id:??) landed as
https://crrev.com/f049582fdaef7b6168058a404a1b8519d3c570f5
Cr-Commit-Position: refs/heads/master@{#408741}