Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2142903003: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in DocumentMarkerController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Now with cool scope thingy. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
index fb62e50657718f5e44de270e0613d16c0c2f8421..e0fb85925682d2e13b643ba9cb25d24b6540e6f9 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
@@ -1788,11 +1788,19 @@ bool Editor::executeCommand(const String& commandName)
if (commandName == "DeleteForward")
return createCommand(AtomicString("ForwardDelete")).execute();
if (commandName == "AdvanceToNextMisspelling") {
- // Wee need to pass false here or else the currently selected word will never be skipped.
+ // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
+ // see http://crbug.com/590369 for more details.
+ frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
+ // We need to pass false here or else the currently selected word will never be skipped.
spellChecker().advanceToNextMisspelling(false);
return true;
}
if (commandName == "ToggleSpellPanel") {
+ // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
+ // see http://crbug.com/590369 for more details.
+ frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
spellChecker().showSpellingGuessPanel();
return true;
}
@@ -1809,6 +1817,10 @@ bool Editor::executeCommand(const String& commandName, const String& value)
return frame().eventHandler().bubblingScroll(ScrollDownIgnoringWritingMode, ScrollByDocument);
if (commandName == "showGuessPanel") {
+ // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.
+ // see http://crbug.com/590369 for more details.
+ frame().document()->updateStyleAndLayoutIgnorePendingStylesheets();
+
spellChecker().showSpellingGuessPanel();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698