third_party/WebKit/Source/web/tests/WebFrameTest.cpp - Issue 2142903003: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in DocumentMarkerController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

Issue 2142903003: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in DocumentMarkerController. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Now with cool scope thingy. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/tests/WebFrameTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

index 84f9eb1f4e07afb6dcec4748c4378baeb7b8a0a7..f8575238dffc8609c72006c437bb057a9ce49f2c 100644

--- a/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebFrameTest.cpp

@@ -5384,6 +5384,9 @@ TEST_P(ParameterizedWebFrameTest, SpellcheckResultErasesMarkers)

element->focus();

NonThrowableExceptionState exceptionState;

document->execCommand("InsertText", false, "welcome ", exceptionState);

+ document->updateStyleAndLayout();

EXPECT_FALSE(exceptionState.hadException());

auto range = EphemeralRange::rangeOfContents(*element);

document->markers().addMarker(range.startPosition(), range.endPosition(), DocumentMarker::Spelling);

« no previous file with comments | « third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp ('k') | no next file » | no next file with comments »