MD Settings: Update passwords section for new cr-shared-menu features

MD Settings: Update passwords section for new cr-shared-menu features

Changes plain divs to buttons, which allow the menus to be interacted
with through tab, enter and escape. Also updates the focus trapping in
cr-shared-menu to support hidden menu items.

BUG=619780
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d
Cr-Commit-Position: refs/heads/master@{#405666}

[tsergeant, 2016-07-14 04:59:32]

Description was changed from

==========
MD Settings: Update passwords section for new cr-shared-menu features

Changes plain divs to buttons, which allow the menus to be interacted
with through tab, enter and escape. Also updates the focus trapping in
cr-shared-menu to support hidden menu items.

BUG=619780
==========

to

==========
MD Settings: Update passwords section for new cr-shared-menu features

Changes plain divs to buttons, which allow the menus to be interacted
with through tab, enter and escape. Also updates the focus trapping in
cr-shared-menu to support hidden menu items.

BUG=619780
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-07-14 05:04:39]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 05:04:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-07-14 05:10:18]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[tsergeant, 2016-07-14 05:10:18]

+dbeam, can you please take a look?

CC hcarmona as FYI

[commit-bot: I haz the power, 2016-07-14 05:37:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 05:37:04]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2016-07-14 17:09:20]

lgtm but why are the 'tap' listeners no longer required?

https://codereview.chromium.org/2142893005/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js (right):

https://codereview.chromium.org/2142893005/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js:139:
'[tabindex]:not([hidden]),button:not([hidden])');
and it starts growing

[tsergeant, 2016-07-15 01:17:48]

Tap listeners are no longer needed since iron-dropdown handles that for us.

https://codereview.chromium.org/2142893005/diff/1/ui/webui/resources/cr_eleme...
File ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js (right):

https://codereview.chromium.org/2142893005/diff/1/ui/webui/resources/cr_eleme...
ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js:139:
'[tabindex]:not([hidden]),button:not([hidden])');
On 2016/07/14 17:09:20, Dan Beam wrote:
> and it starts growing

https://www.youtube.com/watch?v=bWcASV2sey0

https://github.com/PolymerElements/iron-overlay-behavior/pull/200

[tsergeant, 2016-07-15 01:20:24]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2016-07-15 01:20:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 01:26:40]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 01:28:04]

Description was changed from

==========
MD Settings: Update passwords section for new cr-shared-menu features

Changes plain divs to buttons, which allow the menus to be interacted
with through tab, enter and escape. Also updates the focus trapping in
cr-shared-menu to support hidden menu items.

BUG=619780
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Update passwords section for new cr-shared-menu features

Changes plain divs to buttons, which allow the menus to be interacted
with through tab, enter and escape. Also updates the focus trapping in
cr-shared-menu to support hidden menu items.

BUG=619780
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d
Cr-Commit-Position: refs/heads/master@{#405666}
==========

[commit-bot: I haz the power, 2016-07-15 01:28:05]

Patchset 1 (id:??) landed as
https://crrev.com/abecb7d8378980d3e1ba504a1434566d0b74c69d
Cr-Commit-Position: refs/heads/master@{#405666}