chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html - Issue 2142893005: MD Settings: Update passwords section for new cr-shared-menu features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

Issue 2142893005: MD Settings: Update passwords section for new cr-shared-menu features (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js » ('j') | ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

index 138a0da14979034bb8ccb79291f49d89c4d52ca3..2632a0eb3ecbfd2f9b6575fd3bd044cfead85965 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.html

@@ -63,10 +63,10 @@

</div>

<cr-shared-menu id="addressSharedMenu">

- <div id="menuEditAddress" class="list-item menu-item"

- on-tap="onMenuEditAddressTap_">$i18n{editAddress}</div>

- <div id="menuRemoveAddress" class="list-item menu-item"

- on-tap="onMenuRemoveAddressTap_">$i18n{removeAddress}</div>

+ <button id="menuEditAddress" class="list-item menu-item"

+ on-tap="onMenuEditAddressTap_">$i18n{editAddress}</button>

+ <button id="menuRemoveAddress" class="list-item menu-item"

+ on-tap="onMenuRemoveAddressTap_">$i18n{removeAddress}</button>

</cr-shared-menu>

<settings-address-edit-dialog id="addressEditDialog">

</settings-address-edit-dialog>

@@ -109,12 +109,12 @@

</div>

<cr-shared-menu id="creditCardSharedMenu">

- <div id="menuEditCreditCard" class="list-item menu-item"

- on-tap="onMenuEditCreditCardTap_">$i18n{editCreditCard}</div>

- <div id="menuRemoveCreditCard" class="list-item menu-item"

- on-tap="onMenuRemoveCreditCardTap_">$i18n{removeCreditCard}</div>

- <div id="menuClearCreditCard" class="list-item menu-item"

- on-tap="onMenuClearCreditCardTap_">$i18n{clearCreditCard}</div>

+ <button id="menuEditCreditCard" class="list-item menu-item"

+ on-tap="onMenuEditCreditCardTap_">$i18n{editCreditCard}</button>

+ <button id="menuRemoveCreditCard" class="list-item menu-item"

+ on-tap="onMenuRemoveCreditCardTap_">$i18n{removeCreditCard}</button>

+ <button id="menuClearCreditCard" class="list-item menu-item"

+ on-tap="onMenuClearCreditCardTap_">$i18n{clearCreditCard}</button>

</cr-shared-menu>

<settings-credit-card-edit-dialog id="editCreditCardDialog">

</settings-credit-card-edit-dialog>