chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html - Issue 2142893005: MD Settings: Update passwords section for new cr-shared-menu features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

Issue 2142893005: MD Settings: Update passwords section for new cr-shared-menu features (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js ('k') | chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.js » ('j') | ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

index 9f1abbd0c3eae81a03acd4cb0465711c9325275b..822bc5d1d44385c5258dca510f24d998e0e927a6 100644

--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_section.html

@@ -93,11 +93,11 @@

</iron-list>

</div>

<cr-shared-menu id="menu">

- <div id="menuEditPassword" class="list-item menu-item"

+ <button id="menuEditPassword" class="list-item menu-item"

on-tap="onMenuEditPasswordTap_"

- hidden="[[!showPasswords]]">$i18n{editPassword}</div>

- <div id="menuRemovePassword" class="list-item menu-item"

- on-tap="onMenuRemovePasswordTap_">$i18n{removePassword}</div>

+ hidden="[[!showPasswords]]">$i18n{editPassword}</button>

+ <button id="menuRemovePassword" class="list-item menu-item"

+ on-tap="onMenuRemovePasswordTap_">$i18n{removePassword}</button>

</cr-shared-menu>

<password-edit-dialog id="passwordEditDialog"></password-edit-dialog>

<div class="heading">$i18n{passwordExceptionsHeading}</div>