Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2142763002: Cleaned up animation-state-changes.html test to meet W3C standards (Closed)

Created:
4 years, 5 months ago by sashab
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleaned up animation-state-changes.html test to meet W3C standards Cleaned up animation-state-changes.html test to meet W3C standards. Part of web animations test burndown. BUG=623437 Committed: https://crrev.com/3eda0025374cfc23d3e9af70f945f1a7b3ac6fee Cr-Commit-Position: refs/heads/master@{#404989}

Patch Set 1 #

Patch Set 2 : Fixed descriptions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+384 lines, -392 lines) Patch
D third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes.html View 1 chunk +0 lines, -392 lines 0 comments Download
A third_party/WebKit/LayoutTests/web-animations-api/playState-changes.html View 1 1 chunk +384 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
sashab
4 years, 5 months ago (2016-07-12 04:26:28 UTC) #2
alancutter (OOO until 2018)
We should have the description match the reversed animation version: https://codereview.chromium.org/2145453002
4 years, 5 months ago (2016-07-12 05:11:01 UTC) #3
sashab
Done ;D
4 years, 5 months ago (2016-07-12 05:17:58 UTC) #4
sashab
Done ;D
4 years, 5 months ago (2016-07-12 05:17:59 UTC) #5
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-07-12 05:34:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142763002/20001
4 years, 5 months ago (2016-07-12 05:46:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260752)
4 years, 5 months ago (2016-07-12 08:40:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142763002/20001
4 years, 5 months ago (2016-07-13 01:04:32 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 03:55:32 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 03:56:01 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 03:56:54 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3eda0025374cfc23d3e9af70f945f1a7b3ac6fee
Cr-Commit-Position: refs/heads/master@{#404989}

Powered by Google App Engine
This is Rietveld 408576698