Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Issue 2145453002: Animations: Fix play state changes test (Closed)

Created:
4 years, 5 months ago by samli
Modified:
4 years, 5 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Animations: Fix play state changes test BUG=623437 Committed: https://crrev.com/fe9ded7a6424a3808af6c51d5b839c4f0e7cb280 Cr-Commit-Position: refs/heads/master@{#404892}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix play state changes test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -66 lines) Patch
M third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html View 1 20 chunks +70 lines, -66 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
samli
4 years, 5 months ago (2016-07-12 00:36:34 UTC) #2
suzyh_UTC10 (ex-contributor)
I think we need to give each test in this file more descriptive names than ...
4 years, 5 months ago (2016-07-12 02:57:21 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/2145453002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html File third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html (right): https://codereview.chromium.org/2145453002/diff/1/third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html#newcode52 third_party/WebKit/LayoutTests/web-animations-api/animation-state-changes-negative-playback-rate.html:52: assert_unresolved(animation.startTime); All these assertions should have descriptions (I expect ...
4 years, 5 months ago (2016-07-12 04:15:11 UTC) #5
samli
ptal
4 years, 5 months ago (2016-07-12 05:05:33 UTC) #6
alancutter (OOO until 2018)
lgtm
4 years, 5 months ago (2016-07-12 05:06:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145453002/20001
4 years, 5 months ago (2016-07-12 05:27:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/260739)
4 years, 5 months ago (2016-07-12 08:26:21 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2145453002/20001
4 years, 5 months ago (2016-07-12 23:24:51 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-13 02:10:37 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 02:11:45 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:13:05 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fe9ded7a6424a3808af6c51d5b839c4f0e7cb280
Cr-Commit-Position: refs/heads/master@{#404892}

Powered by Google App Engine
This is Rietveld 408576698